Jump to conversation
Unresolved conversations (1)
@bluca bluca Jan 9, 2022
Maybe add a `#define` for this? Magic strings in the middle of a function are not great for readability
src/boot/efi/boot.c
medhefgo
Resolved conversations (6)
@keszybz keszybz Jan 9, 2022
"reset" or "reboot" ?
Outdated
man/loader.conf.xml
@keszybz keszybz Jan 9, 2022
Please give this a more descriptive name. I'm pretty sure that this commit will not be the last time we have to deal with bitlocker, so a single-word description (and a noun in particular), might give us a headache in the future. Maybe "reboot-for-bitlocker" or something like that.
Outdated
man/loader.conf.xml
@keszybz keszybz Jan 9, 2022
!! is not necessary — such a conversion to a boolean happens automatically.
Outdated
src/boot/efi/measure.c
@bluca bluca Jan 9, 2022
This (and the corresponding config) could be more descriptive I think - maybe something like bitlocker_boot_via_reset? A bit longer but more self-descriptive
Outdated
src/boot/efi/boot.c
keszybz
@bluca bluca Jan 9, 2022
/presetn/present/
Outdated
src/boot/efi/boot.c
@bluca bluca Jan 7, 2022
/save/safe/
Outdated
man/loader.conf.xml