network: do not enable IPv4 ACD for IPv4 link-local address if ACD is disabled explicitly #22824
Conversation
|
hmm, so far we tried to avoid boolean options that are prefixed with "Enable", as that is pretty much redundant wording. it's boolean after all... |
yuwata
force-pushed
the
network-dad
branch
2 times, most recently
from
fbf235e
to
7db3b48
Compare
yuwata
changed the title
OK. The renaming part was dropped. PTAL. |
|
The issue is not critical, but the offending commit changed previous behavior. Hence, please backport this to v249 and v250. |
… disabled explicitly The commit 1cf4ed1 makes the IPv4 ACD enabled unconditionally for IPv4 link-local addresses even if users explicitly disable ACD. This makes the IPv4 ACD is enabled by default, but honor user setting. Fixes systemd#22763.
|
I think we can simplify this further. I took the liberty to force-push into your branch, because I thought that just a simple cleanup can be done and I started working on a patch for that. In the end I realized that we can simplify the logic. Please drop my patch if you think it's wrong. |
|
@keszybz No no, you confused the current unfortunate situation: I'd like to adopt something like you posted to clean up the current situation. But please drop the second commit, as it does not work as expected. To make it clear, the very unfortunate code is the following: |
|
(The second commit was dropped. PTAL) |
|
This does not apply cleanly to v250-stable. Please provide a pull request. |
|
@yuwata ^ |
|
Oops. Will do. |
|
v250 backport: systemd/systemd-stable#209 |
The commit yuwata@1cf4ed1 makes the IPv4 ACD
enabled unconditionally for IPv4 link-local addresses even if users
explicitly disable ACD.
This makes the IPv4 ACD is enabled by default, but honor user setting.
Fixes #22763.