Use correct syslog facility number in journald-audit#2304
Closed
aadamowski wants to merge 1 commit intosystemd:masterfrom
Closed
Use correct syslog facility number in journald-audit#2304aadamowski wants to merge 1 commit intosystemd:masterfrom
aadamowski wants to merge 1 commit intosystemd:masterfrom
Conversation
The hardcoded value of "32" for SYSLOG_FACILITY is not valid. This value has probably been taken in the bit shifted form, as it is defined in syslog.h for facility LOG_AUTH. In case of any integrations (rsyslog imjournal?) the value passed on would likely be shifter even further, resulting in an incorrect syslog priority propagated.
poettering
added
the
reviewed/needs-rework 🔨
Contributor
Author
|
I thought that, since all the arguments to After reading about the history of GCC's I'll follow up with a revised patch when I have some time to work on it. |
poettering
added a commit
to poettering/systemd
that referenced
this pull request
Jan 26, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The hardcoded value of "32" for SYSLOG_FACILITY is not valid. This value
has probably been taken in the bit shifted form, as it is defined in
syslog.h for facility LOG_AUTH.
In case of any integrations (rsyslog imjournal?) the value passed on
would likely be shifter even further, resulting in an incorrect syslog
priority propagated.