time-util: fix buffer-over-run #23933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrc0mmand
reviewed
Jul 7, 2022
medhefgo
reviewed
Jul 7, 2022
| @@ -238,6 +238,11 @@ TEST(format_timespan) { | |||
| test_format_timespan_accuracy(1); | |||
| test_format_timespan_accuracy(USEC_PER_MSEC); | |||
| test_format_timespan_accuracy(USEC_PER_SEC); | |||
|
|
|||
| /* See issue #23928. */ | |||
| _cleanup_free_ char *buf; | |||
There was a problem hiding this comment.
I do not know why, but valgrind does not detect the buffer-over-run if buf[5] is used.
ASAN may detect the issue even with buf[5]. But this is just a test code, hence I hope that's no problem.
There was a problem hiding this comment.
I do not know why, but valgrind does not detect the buffer-over-run if
buf[5]is used.
Because valgrind's memcheck doesn't check stack allocations.
poettering
added
the
good-to-merge/waiting-for-ci 👍
keszybz
removed
the
good-to-merge/waiting-for-ci 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23928.