systemd-analyze: Add JSON and table output to systemd-analyze's plot #25790
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
please-review
joshua-zivkovic
changed the title
joshua-zivkovic
force-pushed
the
JZ/plotjson-main
branch
from
00487c4 to
d149a1c
Compare
poettering
requested changes
Jan 6, 2023
poettering
added
analyze
reviewed/needs-rework 🔨
joshua-zivkovic
force-pushed
the
JZ/plotjson-main
branch
from
d149a1c to
5325714
Compare
github-actions
bot
added
please-review
joshua-zivkovic
force-pushed
the
JZ/plotjson-main
branch
from
5325714 to
30209e3
Compare
poettering
reviewed
Jan 11, 2023
poettering
reviewed
Jan 11, 2023
poettering
reviewed
Jan 11, 2023
|
btw, we generally do line breaks at 109ch, as |
poettering
added
reviewed/needs-rework 🔨
Would you mind giving an example of this? I've been following surrounding code for how to deal with formatting on the most part. |
joshua-zivkovic
force-pushed
the
JZ/plotjson-main
branch
from
30209e3 to
9ebfe6b
Compare
github-actions
bot
added
please-review
poettering
added
good-to-merge/waiting-for-ci 👍
|
needs a rebase |
joshua-zivkovic
force-pushed
the
JZ/plotjson-main
branch
from
9ebfe6b to
eec53b8
Compare
yuwata
requested changes
Jan 13, 2023
src/analyze/analyze-plot.c
Outdated
| const BootTimes* boot, | ||
| const char* pretty_times) { | ||
| int m = 1, y = 0; | ||
| UnitTimes* u; |
There was a problem hiding this comment.
Please drop it here, and declare in each for loop.
There was a problem hiding this comment.
The last for loop relies on using u as it was previously changed by the for loop before.
src/analyze/analyze-plot.c
Outdated
| @@ -229,7 +216,7 @@ int verb_plot(int argc, char *argv[], void *userdata) { | |||
| if (boot->kernel_done_time > 0) | |||
| m++; | |||
|
|
|||
| for (u = times; u->has_data; u++) { | |||
| for (u = (UnitTimes*)times; u->has_data; u++) { | |||
There was a problem hiding this comment.
for (UnitTimes *u = times; u->has_data; u++) {
yuwata
added
reviewed/needs-rework 🔨
joshua-zivkovic
force-pushed
the
JZ/plotjson-main
branch
from
eec53b8 to
8101826
Compare
github-actions
bot
added
please-review
|
lgtm. but the ci didn't like it, but it looks like that is the CI's fault, some network issue. could you rebase and push again, to trigger this again? |
poettering
added
needs-rebase
good-to-merge/waiting-for-ci 👍
joshua-zivkovic
force-pushed
the
JZ/plotjson-main
branch
from
8101826 to
a23be57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to have programmatic access to the data presented in systemd-analyze's plot's SVG output, so this PR adds the ability to output
plotdata as JSON or table format. This is controlled by using the--JSON=and--tablecommand line options.Note:
The
show_tablefunction insrc/analyze/analyze-plot.cappears a few times throughout the project so it might be worth re-factoring it intoshared/.