Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chase-symlinks: Rename chase_symlinks() to chase() #26924

Merged
merged 1 commit into from Mar 24, 2023

Conversation

DaanDeMeyer
Copy link
Contributor

Chasing symlinks is a core function that's used in a lot of places so it deservers a less verbose names so let's rename it to chase() and chaseat().

We also slightly change the pattern used for the chaseat() helpers so we get chase_and_openat() and similar.

@github-advanced-security

This comment was marked as off-topic.

src/basic/chase.c Outdated Show resolved Hide resolved
Chasing symlinks is a core function that's used in a lot of places
so it deservers a less verbose names so let's rename it to chase()
and chaseat().

We also slightly change the pattern used for the chaseat() helpers
so we get chase_and_openat() and similar.
@bluca bluca added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed tree-wide and removed repart sysupdate please-review PR is ready for (re-)review by a maintainer labels Mar 24, 2023
Copy link
Member

@keszybz keszybz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too.

@keszybz
Copy link
Member

keszybz commented Mar 24, 2023

Since this is just a rename, if it compiles, it should be fine. We don't need to wait for full CI.

@keszybz keszybz merged commit f461a28 into systemd:main Mar 24, 2023
42 of 47 checks passed
@keszybz keszybz removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants