Skip to content

Support no-journal for dm-integrity devices. - #27824

Merged
yuwata merged 1 commit into
systemd:mainfrom
eatnumber1:integrity-no-journal
May 30, 2023
Merged

yuwata merged 1 commit into
systemd:mainfrom
eatnumber1:integrity-no-journal

Conversation

@eatnumber1

Copy link
Copy Markdown
Contributor

As documented in integritysetup.8, dm-integrity devices support running without a journal whatsoever. This change allows the CRYPT_ACTIVATE_NO_JOURNAL flag (the same as is used with integritysetup --integrity-no-journal) to be passed in during dmsetup by specifying the no-journal option in integritytab.5.

@github-actions github-actions Bot added the please-review PR is ready for (re-)review by a maintainer label May 29, 2023
Comment thread src/integritysetup/integrity-util.c Resolved

@bluca bluca left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document in man/integritytab.xml

@bluca bluca added reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks and removed please-review PR is ready for (re-)review by a maintainer labels May 29, 2023
@eatnumber1
eatnumber1 force-pushed the integrity-no-journal branch from b4558a0 to 4e4bf09 Compare May 29, 2023 23:56
@github-actions github-actions Bot added documentation please-review PR is ready for (re-)review by a maintainer and removed reviewed/needs-rework 🔨 PR has been reviewed and needs another round of reworks labels May 29, 2023
@eatnumber1

Copy link
Copy Markdown
Contributor Author

Please document in man/integritytab.xml

done

Comment thread man/integritytab.xml Resolved
Comment thread man/integritytab.xml Resolved
@eatnumber1
eatnumber1 force-pushed the integrity-no-journal branch from 4e4bf09 to 5dc9b99 Compare May 30, 2023 00:06
Comment thread man/integritytab.xml Resolved
As documented in integritysetup.8, dm-integrity devices support running
without a journal whatsoever. This change allows the
CRYPT_ACTIVATE_NO_JOURNAL flag (the same as is used with `integritysetup
--integrity-no-journal`) to be passed in during dmsetup by specifying
the `no-journal` option in integritytab.5.
@eatnumber1
eatnumber1 force-pushed the integrity-no-journal branch from 5dc9b99 to 26ec404 Compare May 30, 2023 00:19
@bluca bluca added good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed documentation please-review PR is ready for (re-)review by a maintainer labels May 30, 2023
@eatnumber1

Copy link
Copy Markdown
Contributor Author

Should I be concerned about the one CI failure? Looking at it I don't see how my change could have caused this.

@yuwata

yuwata commented May 30, 2023

Copy link
Copy Markdown
Member

Should I be concerned about the one CI failure? Looking at it I don't see how my change could have caused this.

No, that's unrelated.

@yuwata
yuwata merged commit bcc1ee5 into systemd:main May 30, 2023
@eatnumber1

Copy link
Copy Markdown
Contributor Author

Thanks!

@github-actions github-actions Bot removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants