Repository navigation
Support no-journal for dm-integrity devices. - #27824
Merged
Merged
Conversation
bluca
reviewed
May 29, 2023
bluca
requested changes
May 29, 2023
bluca
left a comment
Member
There was a problem hiding this comment.
Please document in man/integritytab.xml
eatnumber1
force-pushed
the
integrity-no-journal
branch
from
May 29, 2023 23:56
b4558a0 to
4e4bf09
Compare
Contributor
Author
done |
bluca
reviewed
May 30, 2023
bluca
reviewed
May 30, 2023
eatnumber1
force-pushed
the
integrity-no-journal
branch
from
May 30, 2023 00:06
4e4bf09 to
5dc9b99
Compare
bluca
reviewed
May 30, 2023
As documented in integritysetup.8, dm-integrity devices support running without a journal whatsoever. This change allows the CRYPT_ACTIVATE_NO_JOURNAL flag (the same as is used with `integritysetup --integrity-no-journal`) to be passed in during dmsetup by specifying the `no-journal` option in integritytab.5.
eatnumber1
force-pushed
the
integrity-no-journal
branch
from
May 30, 2023 00:19
5dc9b99 to
26ec404
Compare
bluca
approved these changes
May 30, 2023
yuwata
approved these changes
May 30, 2023
Contributor
Author
|
Should I be concerned about the one CI failure? Looking at it I don't see how my change could have caused this. |
Member
No, that's unrelated. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As documented in integritysetup.8, dm-integrity devices support running without a journal whatsoever. This change allows the CRYPT_ACTIVATE_NO_JOURNAL flag (the same as is used with
integritysetup --integrity-no-journal) to be passed in during dmsetup by specifying theno-journaloption in integritytab.5.