pam: add call to pam_umask #27870
Merged
pam: add call to pam_umask #27870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting umask for user sessions via UMASK setting in /etc/login.defs is a well-known feature. Let's make sure that user manager also runs with this umask value. Follow-up for 5e37d19.
github-actions
bot
added
the
please-review
|
It looks OK to me. |
fbuihuu
approved these changes
Jun 1, 2023
|
is that pam modulo that commonly used? |
I don't think people change default umask for user sessions often but when they do and setting is not reflected in e.g. gnome-terminal (launched as --user service these days) they are certainly surprised. |
|
Btw, I don't know about any other way to set default umask for user sessions other than setting UMASK= in |
ldv-alt
approved these changes
Jun 7, 2023
ldv-alt
added
good-to-merge/waiting-for-ci 
|
Yeah, this looks reasonable. Similarly to how we added jammy-ppc64el: TEST-29-PORTABLE: FAIL (1813 s), not related. |
keszybz
added
ci-failure-appears-unrelated
and removed
good-to-merge/waiting-for-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting umask for user sessions via UMASK setting in /etc/login.defs is a well-known feature. Let's make sure that user manager also runs with this umask value.
Follow-up for 5e37d19.