integritysetup: support mode=(journal|bitmap|direct) - #27973
Merged
Conversation
github-actions
Bot
added
documentation
please-review
Contributor
Author
|
@eatnumber1 This PR supercedes your commit (PR #27824) that implemented |
Contributor
Author
|
NB, I didn't actually compile or test this code! It's trivial enough that I hope it's acceptable. |
bluca
reviewed
Jun 8, 2023
poettering
reviewed
Jun 8, 2023
poettering
reviewed
Jun 8, 2023
poettering
added
reviewed/needs-rework 🔨
github-actions
Bot
added
please-review
bluca
approved these changes
Jun 8, 2023
poettering
reviewed
Jun 8, 2023
poettering
added
good-to-merge/with-minor-suggestions
and removed
please-review
Member
|
one more fix, and we are good to go |
Add a parameter to the integritytab file to set the mode in which to open the integrity volume. The mode can be journaled (the default), bitmap without a journal, or direct mode without a journal or a bitmap. This change removes the `no-journal' option because it is redundant, being replaced with `mode=direct'. Supercedes commit bcc1ee5, from a week ago, which implemented `no-journal'. Resolves systemd#27587
bluca
added
good-to-merge/waiting-for-ci 👍
github-actions
Bot
removed
the
good-to-merge/waiting-for-ci 👍
Contributor
Yes! This way is better than my change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a parameter to the integritytab file to set the mode in which to open the integrity volume. The mode can be journaled (the default), bitmap without a journal, or direct mode without a journal or a bitmap.
This change removes the
no-journaloption because it is redundant, being replaced withmode=direct.Supercedes commit bcc1ee5, from a week ago, which implemented
no-journal.Resolves #27587