Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop split-usr and unmerged-usr support #27999

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

bluca
Copy link
Member

@bluca bluca commented Jun 12, 2023

As previously announced. This goes all the way, even images that are split-usr won't be usable anymore e.g. as portable images.

@github-actions github-actions bot added documentation fstab-generator meson portable Anything to do with systemd-portable and portablectl and portables sd-hwdb Anything to do with sd-hwdb part of libsystemd sd-path tests userdb util-lib please-review PR is ready for (re-)review by a maintainer labels Jun 12, 2023
@bluca bluca removed documentation util-lib tests fstab-generator portable Anything to do with systemd-portable and portablectl and portables sd-hwdb Anything to do with sd-hwdb part of libsystemd userdb sd-path labels Jun 12, 2023
@yuwata
Copy link
Member

yuwata commented Jun 12, 2023

May not be necessary to do in this PR, but do_test() in test/test-functions should be updated:

systemd/test/test-functions

Lines 3272 to 3275 in 8e81885

# Detect lib paths
[[ "$libdir" ]] || for libdir in /lib64 /lib; do
[[ -d $libdir ]] && libdirs+=" $libdir" && break
done

@yuwata yuwata added ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR and removed ci-fails/needs-rework 🔥 Please rework this, the CI noticed an issue with the PR labels Jun 12, 2023
Copy link
Member

@keszybz keszybz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm surprised how little code that is.

So… should we merge this now, or should we release v254 and only merge it at the beginning of the cycle?

meson.build Show resolved Hide resolved
README Show resolved Hide resolved
README Outdated Show resolved Hide resolved
README Show resolved Hide resolved
@bluca
Copy link
Member Author

bluca commented Jun 12, 2023

I'm surprised how little code that is.

So… should we merge this now, or should we release v254 and only merge it at the beginning of the cycle?

We are in H2 2023 so we should just go for it now. The only question is, do we want to keep support for older images e.g. in portable services?

@bluca
Copy link
Member Author

bluca commented Jun 12, 2023

CIs are sad because:

rpm specifies 'split-usr':

meson.build:3:0: ERROR: Unknown options: "split-usr"

debian/ubuntu expect to find files installed in the legacy dirs - this is going to be fun, as it's either/or, so would need some good timed merges... and break the stable branches CI

@poettering
Copy link
Member

hmm, i figure we should announce this PR on systemd-devel, just in case?

@bluca
Copy link
Member Author

bluca commented Jun 12, 2023

hmm, i figure we should announce this PR on systemd-devel, just in case?

after it's merged, sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meson please-review PR is ready for (re-)review by a maintainer tree-wide
Development

Successfully merging this pull request may close these issues.

None yet

8 participants