Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/service: don't make state transitions based on cgroup state when ExitType=main #28035

Closed
wants to merge 1 commit into from

Conversation

msekletar
Copy link
Contributor

Fixes #27953

@github-actions github-actions bot added the please-review PR is ready for (re-)review by a maintainer label Jun 14, 2023
@mrc0mmand mrc0mmand linked an issue Jun 14, 2023 that may be closed by this pull request
@erikarvstedt
Copy link

It might make sense to add a systemd test to prevent regressions.

@msizanoen1
Copy link
Contributor

msizanoen1 commented Jun 16, 2023

Have you read redhat-plumbers/systemd-rhel8#391 (comment) or #27953 (comment)? This pull request doesn't fix all the other users of main_pid_good that got broken by ff32060. I'm pretty sure that there are other ways to achieve what you need to do on CentOS without resetting main_pid_known.

@poettering
Copy link
Member

So this change doesn't look right to me. if we don't know the main pid and the default ExitType= is set, then we should watch the cgroup, we have nothing else.

So this doesn't look right to me.

I have merged #28000 now, which means I guess we can close this issue here. See that merge for a comment about this.

@poettering poettering closed this Jun 19, 2023
@github-actions github-actions bot removed the please-review PR is ready for (re-)review by a maintainer label Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Service is active (running) after main process has exited libvirtd socket activation not working since 253.5
4 participants