Skip to content

tmpfiles.d: adjust /dev/vfio/vfio access mode #28590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2023
Merged

tmpfiles.d: adjust /dev/vfio/vfio access mode #28590

merged 1 commit into from
Jul 30, 2023

Conversation

mrc0mmand
Copy link
Member

kmod-static-nodes.service sets the mode to 0600, but we want it to be 0666 as specified in 50-udev-default.rules.

Resolves: #28588

@mrc0mmand
tmpfiles.d: adjust /dev/vfio/vfio access mode
11b8e7e 
kmod-static-nodes.service sets the mode to 0600, but we want it
to be 0666 as specified in 50-udev-default.rules.

Resolves: systemd#28588
@github-actions github-actions bot added the please-review PR is ready for (re-)review by a maintainer label Jul 30, 2023
@mrc0mmand mrc0mmand mentioned this pull request Jul 30, 2023
Closed
@bluca bluca added tmpfiles good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed and removed please-review PR is ready for (re-)review by a maintainer labels Jul 30, 2023
@yuwata yuwata merged commit a3d6109 into systemd:main Jul 30, 2023
@github-actions github-actions bot removed the good-to-merge/waiting-for-ci 👍 PR is good to merge, but CI hasn't passed at time of review. Please merge if you see CI has passed label Jul 30, 2023
@mrc0mmand mrc0mmand deleted the tmpfiles-vfio-fix-perms branch July 30, 2023 15:59
@yuwata
Copy link
Member

yuwata commented Aug 4, 2023

Instead, let's fix the ordering, as the offending commit breaks so many setups.

@muncrief
Copy link

muncrief commented Aug 6, 2023

Instead, let's fix the ordering, as the offending commit breaks so many setups.

I'm just an Arch end user and am a bit confused about whether the vfio fix is appropriate or not because of this final comment.

I went ahead and added "z /dev/vfio/vfio 0666 - - -" to "/usr/lib/tmpfiles.d/static-nodes-permissions.conf" and it fixed the problem, and persists across reboots. However I'm concerned about the statement that it will break many setups. Can someone please let me know if the fix is okay?, or what I should be aware of if it's not?

@keszybz
Copy link
Member

keszybz commented Aug 9, 2023

I queued up the revert of the revert of this patch for v254.1 (ca15b59).

@Vitus-TL
Copy link

Vitus-TL commented Dec 9, 2023

ls -al /dev/vfio/noiommu-0
crw------- 1 root root 235, 0 Dec 9 12:09 /dev/vfio/noiommu-0
This one is still broken.. Systemd 253.5-1ubuntu6.1

@YHNdnzj
Copy link
Member

YHNdnzj commented Dec 9, 2023

@Vitus-TL This is properly fixed by #28681 and #28732. Please try with a newer version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluca bluca bluca approved these changes

@yuwata yuwata yuwata approved these changes

Assignees
No one assigned
Labels
tmpfiles
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong permissions for /dev/vfio/vfio
7 participants
@mrc0mmand @yuwata @muncrief @keszybz @Vitus-TL @YHNdnzj @bluca