Fix logind crash if shutdown is called from a non-tty #2887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
|
This seems to happen rarely indeed; I've seen it before, but I haven't found out what causes this. Can you re-run this? (The other two arches were fine) |
It's possible that sd_bus_creds_get_tty() fails and thus scheduled_shutdown_tty is NULL in method_schedule_shutdown(). Fix logind_wall_tty_filter() to get along with that, by showing the message on all TTYs, instead of crashing in strcmp(). https://launchpad.net/bugs/1553040
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that
sd_bus_creds_get_tty()fails and thusscheduled_shutdown_ttyis NULL inmethod_schedule_shutdown().Fix
logind_wall_tty_filter()to get along with that, by showing the message on all TTYs, instead of crashing instrcmp()(see https://launchpadlibrarian.net/245662649/Stacktrace.txt for the stack trace, unfortunately not symbolic)I tried to reproduce this with something like
nohup shutdown +10 -r fooand similar, but didn't manage to get the crash yet. But this is real, https://launchpad.net/bugs/1553040 piles up quite some duplicates.The second commit just fixes a typo, easier to just add that here than a second PR just for that.