machined: do not allow unprivileged users to shell into the root namespace - #39102
Merged
Merged
Conversation
…space We intend to make self-registering machines an unprivileged operation, but currently that would allow an unprivileged user to register a process they own in the root namespace, and then login as any user they like, including root, which is not ideal. Forbid non-root from shelling into a machine that is running in the root user namespace.
github-actions
Bot
added
machine
tests
please-review
github-actions
Bot
removed
the
please-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We intend to make self-registering machines an unprivileged operation, but currently that would allow an unprivileged user to register a process they own in the root namespace, and then login as any user they like, including root, which is not ideal.
Forbid non-root from shelling into a machine that is running in the root user namespace.