system-update-generator: warn if the command line blocks updates #5173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
reviewed
Feb 1, 2017
|
|
||
| r = proc_cmdline_parse(parse_proc_cmdline_item, NULL, 0); | ||
| if (r < 0) | ||
| log_warning_errno(r, "Failed to parse kernel command line, ignoring: %m"); |
There was a problem hiding this comment.
nitpick: No need to have r here, and since the entire function is so small and only being used once, it might be easier to just fold it into main() below?
|
|
||
| target = runlevel_to_target(key); | ||
| if (target) | ||
| log_warning("Offline system update overriden by runlevel \"%s\" on the kernel command line", key); |
There was a problem hiding this comment.
No need to save target here, just `if (!value && runlevel_to_target(key) != NULL) { warn }' would be more succinct.
If "3", "5", "systemd.unit=", or similar are present on the kernel command line, the system will not enter into offline update. This behaviour is in line with the general logic that configuration on the kernel command line has higher priority than the configuration on disk, but is rather surprising. Emit a warning to help users diagnose the situation. https://bugzilla.redhat.com/show_bug.cgi?id=1405439#c4
keszybz
force-pushed
the
offline-update-warning
branch
from
aff8c8d
to
e843722
Compare
|
Yep, much nicer this way. Thanks for the review. Updated with changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If "3", "5", "systemd.unit=", or similar are present on the kernel command line,
the system will not enter into offline update. This behaviour is in line with the
general logic that configuration on the kernel command line has higher priority
than the configuration on disk, but is rather surprising. Emit a warning to help
users diagnose the situation.
https://bugzilla.redhat.com/show_bug.cgi?id=1405439#c4