Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: search preset files in /run #7715

Merged
merged 1 commit into from Jan 5, 2018

Conversation

@johnlinp
Copy link
Contributor

commented Dec 21, 2017

According to systemd.preset(5), presets files in /run should take
effect. However, before this patch, preset files in /run were
ignored.

install: search preset files in /run
According to systemd.preset(5), presets files in /run should take
effect. However, before this patch, preset files in /run were
ignored.
@bl33pbl0p

This comment has been minimized.

Copy link
Contributor

commented Dec 21, 2017

Shouldn't it be placed before /etc/...?

@johnlinp

This comment has been minimized.

Copy link
Contributor Author

commented Dec 21, 2017

@bl33pbl0p No, /etc has the highest priority. This is true in systemd.unit(5) and systemd.preset(5).

@johnlinp

This comment has been minimized.

Copy link
Contributor Author

commented Dec 27, 2017

ping?

@keszybz

This comment has been minimized.

Copy link
Member

commented Jan 5, 2018

I think it'd make sense to have /run with higher priority, because the only way that presets in /run could be useful would be to overwrite temporarily something in /etc or /usr/lib, but that's a different discussion. This patch makes the code match documentation.

@keszybz keszybz merged commit 7c59ab4 into systemd:master Jan 5, 2018

4 of 6 checks passed

Fedora Rawhide Compose x86_64 Build Artifacts -> upstreamfirst-test/logs
Details
xenial-amd64 autopkgtest finished (failure)
Details
Fedora Rawhide CI x86_64 rpm build [succeeded]
Details
artful-i386 autopkgtest finished (success)
Details
artful-s390x autopkgtest finished (success)
Details
semaphoreci The build passed on Semaphore.
Details
@johnlinp

This comment has been minimized.

Copy link
Contributor Author

commented Jan 6, 2018

@keszybz Thank you!

floppym added a commit to gentoo/systemd that referenced this pull request Jan 13, 2018

install: search preset files in /run (systemd#7715)
According to systemd.preset(5), presets files in /run should take
effect. However, before this patch, preset files in /run were
ignored.

(cherry picked from commit 7c59ab4)

Werkov pushed a commit to Werkov/systemd that referenced this pull request Nov 27, 2018

install: search preset files in /run (systemd#7715)
According to systemd.preset(5), presets files in /run should take
effect. However, before this patch, preset files in /run were
ignored.

(cherry picked from commit 7c59ab4)

[fbui: adjust context]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.