Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: search preset files in /run #7715

Merged
merged 1 commit into from
Jan 5, 2018

Conversation

johnlinp
Copy link
Contributor

According to systemd.preset(5), presets files in /run should take
effect. However, before this patch, preset files in /run were
ignored.

According to systemd.preset(5), presets files in /run should take
effect. However, before this patch, preset files in /run were
ignored.
@bl33pbl0p
Copy link
Contributor

Shouldn't it be placed before /etc/...?

@johnlinp
Copy link
Contributor Author

@bl33pbl0p No, /etc has the highest priority. This is true in systemd.unit(5) and systemd.preset(5).

@johnlinp
Copy link
Contributor Author

ping?

@keszybz
Copy link
Member

keszybz commented Jan 5, 2018

I think it'd make sense to have /run with higher priority, because the only way that presets in /run could be useful would be to overwrite temporarily something in /etc or /usr/lib, but that's a different discussion. This patch makes the code match documentation.

@keszybz keszybz merged commit 7c59ab4 into systemd:master Jan 5, 2018
@johnlinp
Copy link
Contributor Author

johnlinp commented Jan 6, 2018

@keszybz Thank you!

floppym pushed a commit to gentoo/systemd that referenced this pull request Jan 13, 2018
According to systemd.preset(5), presets files in /run should take
effect. However, before this patch, preset files in /run were
ignored.

(cherry picked from commit 7c59ab4)
Werkov pushed a commit to Werkov/systemd that referenced this pull request Nov 27, 2018
According to systemd.preset(5), presets files in /run should take
effect. However, before this patch, preset files in /run were
ignored.

(cherry picked from commit 7c59ab4)

[fbui: adjust context]
Werkov pushed a commit to Werkov/systemd that referenced this pull request Jun 3, 2020
According to systemd.preset(5), presets files in /run should take
effect. However, before this patch, preset files in /run were
ignored.

(cherry picked from commit 7c59ab4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants