Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circularise bug 3786 #49

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@stevage
Copy link

commented Mar 22, 2012

Fix #3786 by preventing user trying to circularise problematic shapes like figure-eights.

@systemed

This comment has been minimized.

Copy link
Owner

commented Mar 25, 2012

Will use this logic but want to check first whether it can be done without try... catch (which is usually a last resort).

@stevage

This comment has been minimized.

Copy link
Author

commented Mar 25, 2012

Yeah, I considered trying to pass back the error message more directly, but that also seemed messy. I would have liked to create a custom exception class, but that seems to require a new file, which seemed messy in a different way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.