Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure (practically) all POIs that can be created by the side panel have... #61

Merged
merged 1 commit into from Apr 6, 2012

Conversation

Projects
None yet
2 participants
@rnorris
Copy link

commented Apr 5, 2012

... the corresponding icon on the actual map overlay.


Initially it annoyed me that commonly used POIs eg toilets, benches etc.. only resulted in a green dot on the editing map overlay. Then I realised this is a common problem so I fixed it for most icons.

I think in future if something is added to the side panel - then it also needs displaying on the main map too!

Commit comment follows...


Previously about 40 supported POIs result in a basic green dot on the map. This makes it hard to tell what each one is on the map (apart from selecting each one in turn).

Icons were generated from the existing icons in the resources/features/pois and resources/features/ directories.

Used some bash commands with ImageMagick to resize and name them appropriately - such as:

for x in _24_png; do convert -resize 16x16 $x ../../icons/${x/24/16}; done

Ensure (practically) all POIs that can be created by the side panel h…
…ave the corresponding icon on the actual map overlay.

Previously about 40 supported POIs result in a basic green dot on the map. This makes it hard to tell what each one is on the map (apart from selecting each one in turn).

Icons were generated from the existing icons in the resources/features/pois and resources/features/ directories.

Used some bash commands with ImageMagick to resize and name them appropriately - such as:

for x in *24*png; do convert -resize 16x16 $x ../../icons/${x/24/16}; done

systemed added a commit that referenced this pull request Apr 6, 2012

Merge pull request #61 from rnorris/icons
Ensure (practically) all POIs that can be created by the side panel have...

@systemed systemed merged commit e311aa4 into systemed:master Apr 6, 2012

@systemed

This comment has been minimized.

Copy link
Owner

commented Apr 6, 2012

applauds

Thank you!

@rnorris

This comment has been minimized.

Copy link
Author

commented Apr 6, 2012

Forgot to mention - I think this fixes:
https://trac.openstreetmap.org/ticket/4136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.