Skip to content

Loading…

Ensure (practically) all POIs that can be created by the side panel have... #61

Merged
merged 1 commit into from

2 participants

@rnorris

... the corresponding icon on the actual map overlay.


Initially it annoyed me that commonly used POIs eg toilets, benches etc.. only resulted in a green dot on the editing map overlay. Then I realised this is a common problem so I fixed it for most icons.

I think in future if something is added to the side panel - then it also needs displaying on the main map too!

Commit comment follows...


Previously about 40 supported POIs result in a basic green dot on the map. This makes it hard to tell what each one is on the map (apart from selecting each one in turn).

Icons were generated from the existing icons in the resources/features/pois and resources/features/ directories.

Used some bash commands with ImageMagick to resize and name them appropriately - such as:

for x in 24png; do convert -resize 16x16 $x ../../icons/${x/24/16}; done

@rnorris rnorris Ensure (practically) all POIs that can be created by the side panel h…
…ave the corresponding icon on the actual map overlay.

Previously about 40 supported POIs result in a basic green dot on the map. This makes it hard to tell what each one is on the map (apart from selecting each one in turn).

Icons were generated from the existing icons in the resources/features/pois and resources/features/ directories.

Used some bash commands with ImageMagick to resize and name them appropriately - such as:

for x in *24*png; do convert -resize 16x16 $x ../../icons/${x/24/16}; done
5eaad83
@systemed systemed merged commit e311aa4 into systemed:master
@systemed
Owner

applauds

Thank you!

@rnorris

Forgot to mention - I think this fixes:
https://trac.openstreetmap.org/ticket/4136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 5, 2012
  1. @rnorris

    Ensure (practically) all POIs that can be created by the side panel h…

    rnorris committed
    …ave the corresponding icon on the actual map overlay.
    
    Previously about 40 supported POIs result in a basic green dot on the map. This makes it hard to tell what each one is on the map (apart from selecting each one in turn).
    
    Icons were generated from the existing icons in the resources/features/pois and resources/features/ directories.
    
    Used some bash commands with ImageMagick to resize and name them appropriately - such as:
    
    for x in *24*png; do convert -resize 16x16 $x ../../icons/${x/24/16}; done
Showing with 46 additions and 1 deletion.
  1. BIN resources/icons/accommodation_chalet.n.16.png
  2. BIN resources/icons/accommodation_motel.n.16.png
  3. BIN resources/icons/accommodation_shelter2.n.16.png
  4. BIN resources/icons/amenity_bench.n.16.png
  5. BIN resources/icons/amenity_fountain2.n.16.png
  6. BIN resources/icons/amenity_playground.n.16.png
  7. BIN resources/icons/amenity_post_office.n.16.png
  8. BIN resources/icons/amenity_toilets.n.16.png
  9. BIN resources/icons/amenity_town_hall.n.16.png
  10. BIN resources/icons/amenity_waste_bin.n.16.png
  11. BIN resources/icons/education_nursery3.n.16.png
  12. BIN resources/icons/emergency-telephone-16.png
  13. BIN resources/icons/food_drinkingtap.n.16.png
  14. BIN resources/icons/health_veterinary.n.8E7409.16.png
  15. BIN resources/icons/manmade_lighthouse.png
  16. BIN resources/icons/manmade_tower.png
  17. BIN resources/icons/place_of_worship_unknown.n.16.png
  18. BIN resources/icons/power_station.png
  19. BIN resources/icons/power_substation.n.16.png
  20. BIN resources/icons/power_tower_high2.n.16.png
  21. BIN resources/icons/power_tower_low.n.16.png
  22. BIN resources/icons/shopping_florist.n.16.png
  23. BIN resources/icons/shopping_kiosk.n.16.png
  24. BIN resources/icons/shopping_marketplace.n.16.png
  25. BIN resources/icons/shopping_toys.n.16.png
  26. BIN resources/icons/shopping_vending_machine.n.16.png
  27. BIN resources/icons/sport_leisure_centre.n.16.png
  28. BIN resources/icons/sport_shooting.n.16.png
  29. BIN resources/icons/sport_swimming_outdoor.n.16.png
  30. BIN resources/icons/tourist_art_gallery2.n.16.png
  31. BIN resources/icons/tourist_theme_park.n.16.png
  32. BIN resources/icons/transport_airport_gate.n.16.png
  33. BIN resources/icons/transport_airport_terminal.n.16.png
  34. BIN resources/icons/transport_helicopter_pad.n.16.png
  35. BIN resources/icons/transport_miniroundabout_anticlockwise.n.16.png
  36. BIN resources/icons/transport_weir.n.16.png
  37. BIN resources/icons/transport_zebracrossing.n.16.png
  38. +46 −1 resources/stylesheets/core_pois.css
View
BIN resources/icons/accommodation_chalet.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/accommodation_motel.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/accommodation_shelter2.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/amenity_bench.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/amenity_fountain2.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/amenity_playground.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/amenity_post_office.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/amenity_toilets.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/amenity_town_hall.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/amenity_waste_bin.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/education_nursery3.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/emergency-telephone-16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/food_drinkingtap.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/health_veterinary.n.8E7409.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/manmade_lighthouse.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/manmade_tower.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/place_of_worship_unknown.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/power_station.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/power_substation.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/power_tower_high2.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/power_tower_low.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/shopping_florist.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/shopping_kiosk.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/shopping_marketplace.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/shopping_toys.n.16.png
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
View
BIN resources/icons/shopping_vending_machine.n.16.png
Diff not rendered.
View
BIN resources/icons/sport_leisure_centre.n.16.png
Diff not rendered.
View
BIN resources/icons/sport_shooting.n.16.png
Diff not rendered.
View
BIN resources/icons/sport_swimming_outdoor.n.16.png
Diff not rendered.
View
BIN resources/icons/tourist_art_gallery2.n.16.png
Diff not rendered.
View
BIN resources/icons/tourist_theme_park.n.16.png
Diff not rendered.
View
BIN resources/icons/transport_airport_gate.n.16.png
Diff not rendered.
View
BIN resources/icons/transport_airport_terminal.n.16.png
Diff not rendered.
View
BIN resources/icons/transport_helicopter_pad.n.16.png
Diff not rendered.
View
BIN resources/icons/transport_miniroundabout_anticlockwise.n.16.png
Diff not rendered.
View
BIN resources/icons/transport_weir.n.16.png
Diff not rendered.
View
BIN resources/icons/transport_zebracrossing.n.16.png
Diff not rendered.
View
47 resources/stylesheets/core_pois.css
@@ -5,9 +5,11 @@ node[tourism=guesthouse] { icon-image: icons/accommodation_bed_and_breakfast.n.1
node[tourism=alpine_hut] { icon-image: icons/accommodation_alpinehut.n.16.png; z-index: 20; }
node[tourism=camp_site] { icon-image: icons/accommodation_camping.n.16.png; z-index: 20; }
node[tourism=caravan_site] { icon-image: icons/accommodation_caravan_park.n.16.png; z-index: 20; }
+node[tourism=chalet] { icon-image: icons/accommodation_chalet.n.16.png; z-index: 20; }
node[tourism=guest_house],node[tourism=bed_and_breakfast] { icon-image: icons/accommodation_bed_and_breakfast.n.16.png; z-index: 20; }
node[tourism=hotel] { icon-image: icons/accommodation_hotel.n.16.png; text-offset:15; text: name; font-size: 10; z-index: 20; }
node[tourism=hostel] { icon-image: icons/accommodation_youth_hostel.n.16.png; z-index: 20; }
+node[tourism=motel] { icon-image: icons/accommodation_motel.n.16.png; z-index: 20; }
node[amenity=fire_station] { icon-image: icons/amenity_firestation2.n.16.png; z-index: 20; }
node[amenity=police] { icon-image: icons/amenity_police2.n.16.png; z-index: 20; }
node[amenity=post_box] { icon-image: icons/amenity_post_box.n.16.png; z-index: 20; }
@@ -32,10 +34,27 @@ node[amenity=hospital] { icon-image: icons/health_hospital.n.16.png; z-index: 20
node[amenity=pharmacy] { icon-image: icons/health_pharmacy.n.16.png; z-index: 20; }
node[amenity=atm] { icon-image: icons/money_atm.n.16.png; z-index: 20; }
node[amenity=bank] { icon-image: icons/money_bank2.n.16.png; z-index: 20; }
+/* More Amenities */
+node[amenity=bench] { icon-image: icons/amenity_bench.n.16.png; z-index: 20; }
+node[amenity=drinking_water] { icon-image: icons/food_drinkingtap.n.16.png; z-index: 20; }
+node[amenity=emergency_phone] { icon-image: icons/emergency-telephone-16.png; z-index: 20; }
+node[amenity=fountain] { icon-image: icons/amenity_fountain2.n.16.png; z-index: 20; }
+node[amenity=hunting_stand] { icon-image: icons/sport_shooting.n.16.png; z-index: 20; }
+node[amenity=kindergarten] { icon-image: icons/education_nursery3.n.16.png; z-index: 20; text-offset:15; text: name; font-size: 10; z-index: 20; }
+node[amenity=place_of_worship] { icon-image: icons/place_of_worship_unknown.n.16.png; text-offset:15; text: name; font-size: 10; z-index: 20; }
+node[amenity=post_office] { icon-image: icons/amenity_post_office.n.16.png; z-index: 20; }
+node[amenity=shelter] { icon-image: icons/accommodation_shelter2.n.16.png; z-index: 20; }
+node[amenity=swimming_pool] { icon-image: icons/sport_swimming_outdoor.n.16.png; z-index: 20; }
+node[amenity=townhall] { icon-image: icons/amenity_town_hall.n.16.png; text-offset:15; text: name; font-size: 10; z-index: 20; }
+node[amenity=toilets] { icon-image: icons/amenity_toilets.n.16.png; z-index: 20; }
+node[amenity=vending_machine] { icon-image: icons/shopping_vending_machine.n.16.png; z-index: 20; }
+node[amenity=veterinary] { icon-image: icons/health_veterinary.n.8E7409.16.png; z-index: 20; }
+node[amenity=waste_basket] { icon-image: icons/amenity_waste_bin.n.16.png; z-index: 20; }
+/* Shops */
node[shop=alcohol] { icon-image: icons/shopping_alcohol.n.16.png; z-index: 20; }
node[shop=bakery] { icon-image: icons/shopping_bakery.n.16.png; z-index: 20; }
node[shop=bicycle] { icon-image: icons/shopping_bicycle.n.16.png; z-index: 20; }
-node[shop=book] { icon-image: icons/shopping_book.n.16.png; z-index: 20; }
+node[shop=book], node[shop=books] { icon-image: icons/shopping_book.n.16.png; z-index: 20; }
node[shop=butcher] { icon-image: icons/shopping_butcher.n.16.png; z-index: 20; }
node[shop=car_repair] { icon-image: icons/shopping_car_repair.n.16.png; z-index: 20; }
node[shop=car] { icon-image: icons/shopping_car.n.16.png; z-index: 20; }
@@ -44,16 +63,22 @@ node[shop=confectionery] { icon-image: icons/shopping_confectionery.n.16.png; z-
node[shop=convenience] { icon-image: icons/shopping_convenience.n.16.png; z-index: 20; }
node[shop=doityourself] { icon-image: icons/shopping_diy.n.16.png; z-index: 20; }
node[shop=fishmonger] { icon-image: icons/shopping_fish.n.16.png; z-index: 20; }
+node[shop=florist] { icon-image: icons/shopping_florist.n.16.png; z-index: 20; }
node[shop=garden_centre] { icon-image: icons/shopping_garden_centre.n.16.png; z-index: 20; }
node[shop=gift] { icon-image: icons/shopping_gift.n.16.png; z-index: 20; }
node[shop=greengrocer] { icon-image: icons/shopping_greengrocer.n.16.png; z-index: 20; }
node[shop=hairdresser] { icon-image: icons/shopping_hairdresser.n.16.png; z-index: 20; }
node[shop=hifi] { icon-image: icons/shopping_hifi.n.16.png; z-index: 20; }
node[shop=jewelry] { icon-image: icons/shopping_jewelry.n.16.png; z-index: 20; }
+node[shop=kiosk] { icon-image: icons/shopping_kiosk.n.16.png; z-index: 20; }
node[shop=laundry] { icon-image: icons/shopping_laundrette.n.16.png; z-index: 20; }
+node[amenity=marketplace] { icon-image: icons/shopping_marketplace.n.16.png; z-index: 20; }
node[shop=motorcycle] { icon-image: icons/shopping_motorcycle.n.16.png; z-index: 20; }
node[shop=music] { icon-image: icons/shopping_music.n.16.png; z-index: 20; }
node[shop=supermarket] { icon-image: icons/shopping_supermarket.n.16.png; z-index: 20; }
+node[shop=toys] { icon-image: icons/shopping_toys.n.16.png; z-index: 20; }
+/* More Touristy Items */
+node[tourism=artwork] { icon-image: icons/tourist_art_gallery2.n.16.png; z-index: 20; }
node[historic=archaeological_site] { icon-image: icons/tourist_archaeological.n.16.png; z-index: 20; }
node[historic=battlefield] { icon-image: icons/tourist_battlefield.n.16.png; z-index: 20; }
node[historic=castle] { icon-image: icons/tourist_castle.n.16.png; text-offset:15; text: name; font-size: 10; z-index: 20; }
@@ -61,12 +86,18 @@ node[amenity=cinema] { icon-image: icons/tourist_cinema.n.16.png; z-index: 20; }
node[historic=memorial] { icon-image: icons/tourist_memorial.n.16.png; text-offset:15; text: name; font-size: 10; z-index: 20; }
node[historic=monument] { icon-image: icons/tourist_monument.n.16.png; text-offset:15; text: name; font-size: 10; z-index: 20; }
node[tourism=museum] { icon-image: icons/tourist_museum.n.16.png; text-offset:15; text: name; font-size: 10; z-index: 20; }
+node[tourism=information] { icon-image: icons/tourist_information.png; z-index: 20; }
node[tourism=picnic_site] { icon-image: icons/tourist_picnic.n.16.png; z-index: 20; }
node[historic=ruins] { icon-image: icons/tourist_ruin.n.16.png; z-index: 20; }
node[amenity=theatre] { icon-image: icons/tourist_theatre.n.16.png; z-index: 20; }
+node[tourism=theme_park] { icon-image: icons/tourist_theme_park.n.16.png; z-index: 20; text-offset:15; text: name; font-size: 10; z-index: 20; }
node[tourism=viewpoint] { icon-image: icons/tourist_view_point.n.16.png; z-index: 20; }
node[tourism=zoo] { icon-image: icons/tourist_zoo.n.16.png; z-index: 20; }
+/* Transport */
node[aeroway=aerodrome] { icon-image: icons/transport_aerodrome.n.16.png; z-index: 20; }
+node[aeroway=gate] { icon-image: icons/transport_airport_gate.n.16.png; z-index: 20; }
+node[aeroway=terminal] { icon-image: icons/transport_airport_terminal.n.16.png; z-index: 20; }
+node[aeroway=helipad] { icon-image: icons/transport_helicopter_pad.n.16.png; z-index: 20; }
node[amenity=bus_station] { icon-image: icons/transport_bus_station.n.16.png; z-index: 20; }
node[highway=bus_stop] { icon-image: icons/transport_bus_stop2.n.16.png; z-index: 20; }
node[amenity=fuel] { icon-image: icons/transport_fuel.n.16.png; z-index: 20; }
@@ -80,6 +111,20 @@ node[amenity=taxi] { icon-image: icons/transport_taxi_rank.n.16.png; z-index: 20
node[railway=station] { icon-image: icons/transport_train_station.n.16.png; text-offset:15; text: name; font-size: 10; z-index: 20; }
node[railway=tram_stop] { icon-image: icons/transport_tram_stop.n.16.png; z-index: 20; }
node[leisure=marina] { icon-image: icons/transport_marina.n.16.png; z-index: 20; }
+node[highway=mini_roundabout] { icon-image: icons/transport_miniroundabout_anticlockwise.n.16.png; z-index: 20; }
+node[highway=crossing] { icon-image: icons/transport_zebracrossing.n.16.png; z-index: 20; }
+/* Misc */
+node[leisure=playground] { icon-image: icons/amenity_playground.n.16.png; z-index: 20; }
+node[leisure=sports_centre] { icon-image: icons/sport_leisure_centre.n.16.png; z-index: 20; text-offset:15; text: name; font-size: 10; z-index: 20; }
+/* node[landuse=cemetery], node[landuse=grave_yard] { icon-image: icons/?.png; z-index: 20; } */
+node[man_made=survey_point] { icon-image: icons/manmade_lighthouse.png; z-index: 20; }
+node[man_made=tower] { icon-image: icons/manmade_tower.png; z-index: 20; }
+/* Yes these power stations seem a little backward - but that's seemingly what the side menu uses ATM */
+node[power=station] { icon-image: icons/power_substation.n.16.png; z-index: 20; }
+node[power=generator] { icon-image: icons/power_station.png; z-index: 20; text-offset:15; text: name; font-size: 10; z-index: 20; }
+node[power=tower] { icon-image: icons/power_tower_high2.n.16.png; z-index: 20; }
+node[power=pole] { icon-image: icons/power_tower_low.n.16.png; z-index: 20; }
+node[waterway=weir] { icon-image: icons/transport_weir.n.16.png; z-index: 20; }
/* Addressing */
Something went wrong with that request. Please try again.