Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing named-exports to not alter default export. #1983

Merged
merged 2 commits into from Aug 23, 2019

Conversation

@joeldenning
Copy link
Collaborator

commented Aug 20, 2019

See this codepen for the weird behavior that this fixes.

The named-exports extra is accidentally changing the default export, if the exported object has a default property on it.

joeldenning added 2 commits Aug 20, 2019
@guybedford guybedford merged commit 41fc17c into master Aug 23, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@guybedford guybedford deleted the named-exports-default branch Aug 23, 2019
@joeldenning joeldenning referenced this pull request Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.