Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links on Homepage redirects to 400 Bad Request page #467

Open
isabelcosta opened this issue Dec 14, 2019 · 5 comments · May be fixed by #468
Open

Links on Homepage redirects to 400 Bad Request page #467

isabelcosta opened this issue Dec 14, 2019 · 5 comments · May be fixed by #468

Comments

@isabelcosta
Copy link
Member

@isabelcosta isabelcosta commented Dec 14, 2019

Description

As a user,
I need the links on the homepage to be correct,
so that I can learn more about AnitaB.org communities.

When clicking some buttons on the homepage, I get redirected to 400 Bad Request, because old website - http://anitaborg.org/ - does not redirect to the current AnitaB official website - https://anitab.org/.

E.g.: http://anitaborg.org/get-involved/systers/systers-initiatives/ should be http://anitab.org/get-involved/systers/systers-initiatives/ (which actually like this, redirects to https://anitab.org/systers/systers-initiatives/)

I think the file that handles this is /develop/systers_portal/templates/common/index.html.

Mocks

What I get right now:
image

Acceptance Criteria

Update [Required]

  • Make all links on homepage redirect to a valid page instead of 400 Bad Request

Definition of Done

  • All of the required items are completed.
  • Approval by 1 mentor.

Estimation

1 hour

@cervantez07

This comment has been minimized.

Copy link

@cervantez07 cervantez07 commented Dec 14, 2019

I'm not sure if I did this correctly or not, but I tried to propose changes on the file. I told me that the files were the same?

I clicked edit on your file, copied it to notepad++, made changes, pasted it back in and clicked propose changes after writing notes.

@isabelcosta

This comment has been minimized.

Copy link
Member Author

@isabelcosta isabelcosta commented Dec 14, 2019

Did you create a Pull Request as a result of your proposed changes? Did you do this on your fork or on this repository? @cervantez07 Can you link here the changes you did?

What you would do here would be:

  1. forking the project
  2. change on your forked repository cervantez07/portal , the file you would have to change
  3. submit the Pull Request

But before submitting the pull request, it would be could to run the code and test it out locally to see if the change you done was on the right file, and was reflected on the homepage.

How does this sound @cervantez07 ?

@sp00p sp00p linked a pull request that will close this issue Dec 15, 2019
5 of 5 tasks complete
@pianeta051

This comment has been minimized.

Copy link

@pianeta051 pianeta051 commented Dec 15, 2019

Hi Isabel,

Would you like me to help you with this?.
Is anyone working on this?

@sayashraaj

This comment has been minimized.

Copy link

@sayashraaj sayashraaj commented Dec 15, 2019

Can I work on this please? This is my domain of interest and I would love to work on this

@isabelcosta

This comment has been minimized.

Copy link
Member Author

@isabelcosta isabelcosta commented Dec 17, 2019

@pianeta051 @sayashraaj you're welcome to contribute to this project :) Although I'm not a maintainer for this specific project so I won't be able to merge and such.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.