Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings broken after new theme was installed #3403

Closed
incognico opened this issue Nov 25, 2018 · 2 comments
Closed

Settings broken after new theme was installed #3403

incognico opened this issue Nov 25, 2018 · 2 comments

Comments

@incognico
Copy link
Contributor

@incognico incognico commented Nov 25, 2018

I installed this theme and after that it's not possible for me to open settings anymore.

--- src/client/app/theme.ts     2018-10-15 23:17:49.370916000 +0200
+++ /tmp/asdf   2018-11-25 16:11:23.860601000 +0100
@@ -15,13 +15,15 @@
 export const pinkTheme: Theme = require('../theme/pink.json5');
 export const blackTheme: Theme = require('../theme/black.json5');
 export const halloweenTheme: Theme = require('../theme/halloween.json5');
+export const heckermanTheme: Theme = require('../theme/heckerman.json5');

 export const builtinThemes = [
        lightTheme,
        darkTheme,
        pinkTheme,
        blackTheme,
-       halloweenTheme
+       halloweenTheme,
+       heckermanTheme
 ];

 export function applyTheme(theme: Theme, persisted = true) {

theme/heckerman.json5

{
        id: '2072b8be-c80a-402b-a292-08844f0a0cc6',

        name: 'Heckerman',
        author: 'rndtrash',

        base: 'dark',

        vars: {
                primary: 'rgb(39, 174, 96)',
                secondary: 'rgb(17, 17, 17)',
                text: 'rgb(46, 204, 113)',
        },

        props: {
                renoteGradient: '#092A17',
                renoteText: '$primary',
                quoteBorder: '$primary',
        },
}

➡️ 💥

image

What is happening? All is fine without the theme.

😕

@incognico

This comment has been minimized.

Copy link
Contributor Author

@incognico incognico commented Nov 25, 2018

Surprisingly it works in node_env development.

@incognico

This comment has been minimized.

Copy link
Contributor Author

@incognico incognico commented Nov 25, 2018

It was the fault of id: '2072b8be-c80a-402b-a292-08844f0a0cc6', it's now 'heckerman' and it works. 😌

@incognico incognico closed this Nov 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.