New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some extra minor tests #10

Merged
merged 2 commits into from Jun 30, 2015

Conversation

Projects
None yet
2 participants
@ambs
Contributor

ambs commented Jun 24, 2015

Hey

First, expanded tabs to four spaces in the main module. It was using spaces in some places, and tabs in other, so, preferred to keep spaces (four). Any way, we can remove that commit if you like.

Other than that, tested if we can send the curl object to the callback function (yes we can) and if we can obtain the current download speed. Also, tested the content type is available and has a sensible value.

And only now, when writing about the possibility to add a default of sending the curl object in case no progress data is set, I find out that is already implemented. Damn, an easy and interesting patch I could write, and it is not needed 馃槃

@szbalint

This comment has been minimized.

Show comment
Hide comment
@szbalint

szbalint Jun 30, 2015

Owner

Thanks for the tests Alberto!

I might do a new release soon, integrating these changes.

Owner

szbalint commented Jun 30, 2015

Thanks for the tests Alberto!

I might do a new release soon, integrating these changes.

szbalint added a commit that referenced this pull request Jun 30, 2015

Merge pull request #10 from ambs/master
Some extra minor tests

@szbalint szbalint merged commit c09f532 into szbalint:master Jun 30, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment