Run tests on lowest deps also

[szepeviktor]

@herndlm Here we go 🐎

From #122 (comment)

[szepeviktor]

• Locking wp-coding-standards/wpcs (2.1.0)

Root of CS errors.

[herndlm]

yep, the phpcs errors can be fixed by upgrading the non direct dependency wp-coding-standards/wpcs from 2.1.0 to 2.3.0 but then some other CS errors show up, but it's a step forward

[szepeviktor]

upgrading the non direct dependency wp-coding-standards/wpcs

Done.

[herndlm]

composer require --dev szepeviktor/phpcs-psr-12-neutron-hybrid-ruleset:^0.6.1 automattic/phpcs-neutron-standard:^1.7 fixes all phpcs errors but one

[szepeviktor]

Let's just ignore CS.
I'm not willing to fiddle with my (unused, as I do not write code) CS for hours.

[herndlm]

the dev deps in general are not important at all for the lowest deps test IMO. annoying that they get downgraded

[herndlm]

a good pragmatical solution might be to run the lowest tests with just e.g. composer update --prefer-lowest --prefer-stable php-stubs/wordpress-stubs phpstan/phpstan. maybe the symfony polyfill too if you want, then we have all non-dev deps :)

[herndlm]

looks like you're determined to fix it 🎉
for the stub-dependency I think I can build you some conditional tests. e.g. one mysql2date for WP 5 and one for WP 6 or so, or just lock them to WP 6

[szepeviktor]

@herndlm Dev deps fixed!

• Locking php-stubs/wordpress-stubs (v4.7.14)

How to handle inconsistent WP types?

[szepeviktor]

AFAIK WP 6.0 introduced meaningful types. Up to 5.0 types were mainly ignored.

[szepeviktor]

You can't cook a tasty soup from mud!!

[herndlm]

hehe, I wanted to suggest to wrap some tests maybe in something like

if (InstalledVersions::satisfies(new VersionParser(), 'php-stubs/wordpress-stubs', '^5.0')) {
            yield from $this->gatherAssertTypes(__DIR__ . '/data/wp_error_parameter.php');
        }

but locking the stubs should be fine, right. lower phpstan version is the most interesting thing most likely :)

[herndlm]

I think this makes sense, thx Viktor