Fix AssertWpErrorTypeSpecifying extensions #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All green |
|
Only 1 thing (2 occurrences) - $yes = $yes;
+ $yes = $_GET['yes'];Would it be possible? |
|
Should be possible. The type is specified via phpdoc and overwritten anyways. I'm just not in front of the computer anymore, so feel free to adapt if you want |
|
Also the diff I produced on one test file is not needed and could be reverted. Sorry, I was in a hurry and missed that.. |
|
Thank you Martin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Viktor you were right, this was autoloader related. PHPStan needs to be able to cleanly autoload this class in order to fire the extensions. This is my first hacky approach to fix that autoloading with some kind of stub class copied into the tests folder.
The rest are just tiny fixes for the extensions themselves.
Refs: #124 CC @swissspidy