Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple variants #135

merged 2 commits into from Dec 1, 2022


Copy link
Sponsor Contributor

@johnbillion johnbillion commented Dec 1, 2022

Fixes #133.

This fixes the immediate issue where an exception is thrown by PHPStan when an action or filter callback has multiple variants. It's not a complete fix because the multiple callbacks are not all analysed and therefore problems with a variant that isn't the first one found will not be identified, but I need to investigate how to fix that and it'll probably take a while.

@szepeviktor This can go into a patch release while I work on full support for multiple callbacks.

@johnbillion johnbillion marked this pull request as ready for review December 1, 2022 14:51
Copy link

This can go

🖖🏻 All right.

@szepeviktor szepeviktor merged commit 2778454 into szepeviktor:master Dec 1, 2022
1 check passed
@johnbillion johnbillion deleted the 133-multiple-variants branch December 1, 2022 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

Internal error: Internal error: Multiple variants - use selectFromArgs() instead.
2 participants