Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'update' changes entries in package.json #4

Closed
szimek opened this issue Aug 29, 2016 · 1 comment
Closed

'update' changes entries in package.json #4

szimek opened this issue Aug 29, 2016 · 1 comment

Comments

@szimek
Copy link
Owner

szimek commented Aug 29, 2016

update command calls npm update --save/--save-dev - this not only updates npm-shrinkwrap.json file (which is ok), but also package.json (which is not ok) - e.g. if one has "eslint": "*" entry in their package.json file and updates it with bundlejs update, they'll end up with "eslint": "^x.x.x" entry (with the default npm config).

Not sure what the best solution would be, either it could maybe cleanup package.json file after running update using data from .bundlerjs.json file or it could do the same as bundle install does, i.e. update everything without using --save/--save-dev options and then re-create npm-shrinkwrap.json file.

@szimek
Copy link
Owner Author

szimek commented Aug 29, 2016

Closed by f59c265.

Turns out that npm install --save-dev and npm update --save-dev doesn't update npm-shrinkwrap.json file... Thus, it always calls npm update --save <packages> and then recreates package.json file, so that it looks exactly the same as before running 'update' command.

@szimek szimek closed this as completed Aug 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant