Material without thickness entries can exist (and cause strange behaviour) #123

Closed
pbrier opened this Issue Mar 26, 2013 · 6 comments

Comments

Projects
None yet
3 participants
Contributor

pbrier commented Mar 26, 2013

if a new material is made, it does not have a "thickness" entry and this causes strange behaviour.

A material should always have a single entry (thickness "0"). It should not be able to delete it.

Contributor

mgmax commented Mar 26, 2013

Could you please explain the "strange behaviour" in detail?

I'm looking for an alternative to your solution because it can be
confusing if you add "Wood" and then you have "Wood, thickness 0"
selected, need to add e.g. thickness 4mm and remove the meaningless
thickness 0.

Contributor

pbrier commented Mar 26, 2013

Speed and power settings are ignored for anything but the first profile in the job (in case of laos laser)

mgmax notifications@github.com schreef:

Could you please explain the "strange behaviour" in detail?

I'm looking for an alternative to your solution because it can be
confusing if you add "Wood" and then you have "Wood, thickness 0"
selected, need to add e.g. thickness 4mm and remove the meaningless
thickness 0.


Reply to this email directly or view it on GitHub:
#123 (comment)

Verzonden van mijn Android telefoon met K-9 Mail.

Contributor

mgmax commented Mar 28, 2013

It is difficult to find a really good solution.
Part 1: Show an error message when trying to execute a job without
material thickness, refuse to start the job.
"Error: You have not set a material thickness. Please add a material
thickness."

Part 2: Warn the user before, so that he does not edit around in
laser-settings that will never be saved. But how? He does not think
there's anything wrong with the empty size-box, so he will blame VisiCut
for locking the laser-settings ("maybe it is some bug, I did everything
correctly").

Adding a "0" entry is bad, and asking the user for the value is not
good either: Imagine you click at Wood instead of Paper although you
wanted to click on Paper, then you are confused by a dialogbox asking
you to enter the thickness of Wood. You probably then click "abort", but
in which state is the program now?

Contributor

peteruithoven commented Mar 31, 2013

Maybe I'm missing an angle, but why not require at least 1 thickness when you add / edit a material (adding a validation on the material form)? A error dialog could be shown when you try to save a material, something like "A material should have at least one thickness".
This doesn't solve the problem for existing materials with no thickness, for that you could add the error mgmax suggests and refuse to start the job.

I'm against adding a random thickness. I added another issue on adding a thickness: issue #134.

Contributor

mgmax commented Apr 7, 2013

@peteruithoven you're completely right. We should just force adding a thickness. Because the materials without a thickness are only left over from using development versions, we can save a lot of effort and just add a "0" thickness silently.

Contributor

mgmax commented Apr 7, 2013

I'm working on it.
@peteruithoven I need a NL translation for: You have not added a thickness yet. Please add at least one material thickness by clicking the "+" button.

@mgmax mgmax added a commit to mgmax/VisiCut that referenced this issue Apr 7, 2013

@mgmax mgmax Add "0.0mm" for materials without thickness. Prevents #123 70a1795

t-oster closed this in 4559a1a Apr 9, 2013

@t-oster t-oster added a commit that referenced this issue Apr 9, 2013

@t-oster t-oster Merge pull request #141 from mgmax/develop
Fix #123: Materials without any thickness
ba5a11d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment