Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid timestamp #117

Closed
pdepaepe opened this issue Feb 16, 2017 · 11 comments
Closed

Invalid timestamp #117

pdepaepe opened this issue Feb 16, 2017 · 11 comments

Comments

@pdepaepe
Copy link

Hello,

GELF Format Specification Version 1.1 (11/2013) expect a number as timestamp http://docs.graylog.org/en/2.2/pages/gelf.html but the library send a String:

https://github.com/t0xa/gelfj/blob/master/src/main/java/org/graylog2/GelfMessage.java#L227

This is a problem for any input respecting GELF format specification as all logs emit by the library will be drop because of invalid timestamp.

Thanks.

@joschi
Copy link
Contributor

joschi commented Jul 25, 2017

This came up in a bug report for Graylog 2.3.0-rc.2: Graylog2/graylog2-server#4027

The "timestamp" field should definitely be a floating point number and not a string.

@bonzi316
Copy link

bonzi316 commented Nov 9, 2017

+1

any ETA on this ? It is hurting my app and we are dropping a lots of messages.

Thanks

@joschi
Copy link
Contributor

joschi commented Nov 10, 2017

@bonzi316 Graylog doesn't drop GELF messages in which the timestamp field is a string.

See the referenced Graylog2/graylog2-server#4027 for details.

@tholu
Copy link

tholu commented Jan 7, 2018

This no longer seems to be true for graylog 2.4.0 (messages are not appearing anymore).

todvora pushed a commit to todvora/gelfj that referenced this issue Jan 8, 2018
@jasonvangundy
Copy link

jasonvangundy commented Jan 8, 2018

@tholu I am seeing the same behavior. My graylog logs are filling up with warnings calling out invalid timestamps. I had read they should be processed still, per @joschi, but I do not see gelfj messages indexed in graylog at all. Looks like @todvora may have a fix. Are you thinking of PRing that back here?

@tholu
Copy link

tholu commented Jan 8, 2018

@jasonvangundy This repo does not seem to be maintained anymore. You can use v1.1.16 from https://github.com/todvora/gelfj/releases via https://jitpack.io/ to fix it (already tested and in production).

@jasonvangundy
Copy link

Thanks @tholu ! You must be getting a different result than I am. You aren't seeing the following? https://jitpack.io/com/github/todvora/gelfj/v1.1.16/build.log

@todvora
Copy link

todvora commented Jan 8, 2018

Sorry about that, @jasonvangundy - this is a failed and cached build. You can now get the v1.1.17, which builds fine: https://jitpack.io/#todvora/gelfj/v1.1.17

@todvora
Copy link

todvora commented Jan 8, 2018

Here is my PR with the mentioned fix: #121

@t0xa t0xa closed this as completed in #121 Jan 8, 2018
@t0xa
Copy link
Owner

t0xa commented Jan 8, 2018

@todvora Thanks for PR. Merged and released as v1.1.16. Should be available in Central shortly.

Edit: mistyped released version

@todvora
Copy link

todvora commented Jan 8, 2018

Awesome, thank you @t0xa!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants