Skip to content

libs should support <scope>, <systemPath> for local jars #53

Closed
russt opened this Issue Mar 1, 2012 · 14 comments

3 participants

@russt
russt commented Mar 1, 2012

would be nice if <lib> configuration element supported local jars, i.e.,

<libs>
<jarArtifact>
<groupId>com.bar</groupId>
<version>1.0</version>
<scope>system</scope>
<artifactId>foo</artifactId>
<systemPath>/tmp/foo.jar</systemPath>
</jarArtifact>
</libs>

workaround is to install local jars in m2/repository.

@jbellmann jbellmann was assigned Mar 1, 2012
@jbellmann
A Tomcat 7 Maven Plugin member

Hi russt,

should not be so difficult to implement. Comes with the next milestone (maybe april).

Cheers
Jörg

@marcobuss marcobuss was assigned Mar 10, 2012
@marcobuss
A Tomcat 7 Maven Plugin member

hi,

i will do it until next week but i dont understand why somebody should use it that way. There is no difference between copy a configuration jar and copy all configuration files to every project.

Cheers
Marco

@russt
russt commented Mar 10, 2012
@marcobuss
A Tomcat 7 Maven Plugin member

The default way to provide tomcat configuration e.g. setting JNDI resources in context.xml is to copy your configurations under /src/main/tomcat.
This Dir will be copied into the tomcat root directory. So you can overwrite the default files with your project specific ones.

We used this to define a bunch of JMS and database resources in context.xml. Because we have a lot of projects we had to changed this configuration in every projekt if one resource has to be changed. So the configuration.jar feature is realy useful for us.

An example can be found here: https://github.com/t7mp/examples/tree/master/simple

Is this an adequate solution for your problem? If yes i won't implement this feature because i think providing the configuration as files in the configuration directory is the same as putting a jar with the configuration into the projekt.

@russt
russt commented Mar 11, 2012
@marcobuss
A Tomcat 7 Maven Plugin member

Ok, i missunderstood the issue. Now it is clear to me. Verry usefull feature I hope to get it done during the upcomming week.

@jbellmann
A Tomcat 7 Maven Plugin member

Hi all,

I implemented this feature in the last days. Russt can you please verify that it works for you. You can find an example configuration here. It is not necessary to specify an 'scope'. That makes no sense in this case.
Let us know and reopen this issue if it do not work for you. The version you have to use is 0.9.10.M2. That version should be available in central on monday.

Cheers
Jörg

@jbellmann jbellmann closed this Mar 24, 2012
@russt
russt commented Mar 26, 2012
@jbellmann jbellmann reopened this Mar 27, 2012
@jbellmann
A Tomcat 7 Maven Plugin member

Hi russt,

thanks for your response. I will have a look what's going wrong.

Cheers
Jörg

@jbellmann
A Tomcat 7 Maven Plugin member

Hi Russ,

sorry but I couldn't reproduce the exception. I added one more integration-test for running in forked mode but all integration-tests were successful. I also use the specified version (0.9.10.M2) on the examples project. Without any exception. All my tests were executed with Maven 3.0.4. What version do you use?

Cheers
Jörg

@jbellmann
A Tomcat 7 Maven Plugin member

Hi Marco,

can you please verify that version 0.9.10.M2 works?
Thank you.

MfG
Jörg

@russt
russt commented Mar 28, 2012
@jbellmann
A Tomcat 7 Maven Plugin member

Hi Russ,

I hope the latest release 0.9.10.M3 works better for you ;-). The tests passed successfully with Maven 2. Please try again when the plugin will be available at central.

Cheers
Jörg

@jbellmann jbellmann closed this Mar 30, 2012
@russt
russt commented Mar 30, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.