Make BracketFinder aware of inside/outside of double-quote #642

Merged
merged 4 commits into from Jan 3, 2017

Projects

None yet

1 participant

@t9md
Owner
t9md commented Jan 3, 2017 edited

Fix #556

Behavior change

  • When BracketFinder search from
    • inside of double-quote: Find char from all area(don't care found char is inside/outside of double-quote).
    • outside of double-quote: Find char only from outside of double-quote.

I noticed resulting behavior is still slightly different from pure-Vim.
I cannot say which is sensible behavior in corner case(e.g. quote is un-balanced in one-line and try to find bracket in double-quote)
From my impression, pure-Vim also seems to work deterministic way.

added some commits Jan 3, 2017
@t9md 🔥 leftover, passing never used argument 4ce0d67
@t9md bracket-finder search char outside of duple-quote if search start fro…
…m outside of double-quote
af214b7
@t9md 📝 9767f40
@t9md Make explicit that un-balanced quote is never be in-quote
ee2d890
@t9md t9md merged commit ee2d890 into master Jan 3, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@t9md t9md added a commit that referenced this pull request Jan 4, 2017
@t9md duble-quote-awarenss of bracket pair #642 #556 cc666e9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment