From 25755af826f5f28754e5af15bf20dd86d7d24043 Mon Sep 17 00:00:00 2001 From: Liz Baron <10554+lizbaron@users.noreply.github.com> Date: Wed, 22 Dec 2021 16:12:15 -0500 Subject: [PATCH 01/10] testing new value --- CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep index 36697091c..b9e35bb16 100644 --- a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep +++ b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep @@ -1,7 +1,7 @@ param sqlConnectivityType string = 'Public' param sqlPortNumber int = 41433 param sqlStorageWorkloadType string = 'DW' -param sqlStorageDisksConfigurationType string = 'NEW' +param sqlStorageDisksConfigurationType string = 'ADD' param sqlAutopatchingDayOfWeek string = 'Sunday' param sqlAutopatchingStartHour int = 2 param sqlAutopatchingWindowDuration int = 60 From b8206b2ed7e0bf2ce38143798573c2561a5818a8 Mon Sep 17 00:00:00 2001 From: Liz Baron <10554+lizbaron@users.noreply.github.com> Date: Wed, 22 Dec 2021 16:39:34 -0500 Subject: [PATCH 02/10] made up some parameters --- .../CreateSqlVirtualMachineTemplate.bicep | 20 +++++++++++++++++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep index b9e35bb16..6215b1833 100644 --- a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep +++ b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep @@ -1,7 +1,12 @@ param sqlConnectivityType string = 'Public' param sqlPortNumber int = 41433 -param sqlStorageWorkloadType string = 'DW' -param sqlStorageDisksConfigurationType string = 'ADD' +param sqlStorageWorkloadType string = 'General' +param sqlStorageDisksConfigurationType string = 'NEW' +param sqlDataSettingsDefaultFilePath string = 'F:\\SQLData' +param sqlDataSettingsLUNs array = array(1) +param sqlLogSettingsDefaultFilePath string = 'G:\\SQLData' +param sqlLogSettingsLUNs array = array(1) +param sqlTempDbSettingsDefaultFilePath string = 'H:\\SQLData' param sqlAutopatchingDayOfWeek string = 'Sunday' param sqlAutopatchingStartHour int = 2 param sqlAutopatchingWindowDuration int = 60 @@ -29,6 +34,17 @@ resource newVMName_resource 'Microsoft.SqlVirtualMachine/SqlVirtualMachines@2017 } storageConfigurationSettings: { diskConfigurationType: sqlStorageDisksConfigurationType + sqlDataSettings : { + luns: sqlDataSettingsLUNs + defaultFilePath: sqlDataSettingsDefaultFilePath + } + sqlLogSettings: { + luns: sqlLogSettingsLUNs + defaultFilePath: sqlLogSettingsDefaultFilePath + } + sqlTempDbSettings: { + defaultFilePath: sqlTempDbSettingsDefaultFilePath + } storageWorkloadType: sqlStorageWorkloadType } serverConfigurationsManagementSettings: { From 079c6c8728aa8b74734e02c7a12026b93674607f Mon Sep 17 00:00:00 2001 From: Liz Baron <10554+lizbaron@users.noreply.github.com> Date: Wed, 22 Dec 2021 16:45:12 -0500 Subject: [PATCH 03/10] Perhaps this change will fix, "Invalid Logical Unit numbers specified. Different drive could not reuse the same Logical Unit number." --- CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep index 6215b1833..cc5f199d4 100644 --- a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep +++ b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep @@ -5,7 +5,7 @@ param sqlStorageDisksConfigurationType string = 'NEW' param sqlDataSettingsDefaultFilePath string = 'F:\\SQLData' param sqlDataSettingsLUNs array = array(1) param sqlLogSettingsDefaultFilePath string = 'G:\\SQLData' -param sqlLogSettingsLUNs array = array(1) +param sqlLogSettingsLUNs array = array(2) param sqlTempDbSettingsDefaultFilePath string = 'H:\\SQLData' param sqlAutopatchingDayOfWeek string = 'Sunday' param sqlAutopatchingStartHour int = 2 From f955b2e81a6ec7d6672f3698895b4bd181b0c8ef Mon Sep 17 00:00:00 2001 From: Liz Baron <10554+lizbaron@users.noreply.github.com> Date: Wed, 22 Dec 2021 16:57:20 -0500 Subject: [PATCH 04/10] starting at zero for LUNs --- CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep index cc5f199d4..ea625831b 100644 --- a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep +++ b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep @@ -3,9 +3,9 @@ param sqlPortNumber int = 41433 param sqlStorageWorkloadType string = 'General' param sqlStorageDisksConfigurationType string = 'NEW' param sqlDataSettingsDefaultFilePath string = 'F:\\SQLData' -param sqlDataSettingsLUNs array = array(1) +param sqlDataSettingsLUNs array = array(0) param sqlLogSettingsDefaultFilePath string = 'G:\\SQLData' -param sqlLogSettingsLUNs array = array(2) +param sqlLogSettingsLUNs array = array(1) param sqlTempDbSettingsDefaultFilePath string = 'H:\\SQLData' param sqlAutopatchingDayOfWeek string = 'Sunday' param sqlAutopatchingStartHour int = 2 From e05b3f39905f27301247f432ea313312274aa980 Mon Sep 17 00:00:00 2001 From: Liz Baron <10554+lizbaron@users.noreply.github.com> Date: Wed, 22 Dec 2021 17:33:08 -0500 Subject: [PATCH 05/10] nothing works. Everything is terrible. --- CI/Azure-DevOps/CreateSQLVM_azcli.ps1 | 2 +- .../CreateSqlVirtualMachineTemplate.bicep | 28 +++++++++---------- 2 files changed, 15 insertions(+), 15 deletions(-) diff --git a/CI/Azure-DevOps/CreateSQLVM_azcli.ps1 b/CI/Azure-DevOps/CreateSQLVM_azcli.ps1 index c347309b4..dcc66febc 100644 --- a/CI/Azure-DevOps/CreateSQLVM_azcli.ps1 +++ b/CI/Azure-DevOps/CreateSQLVM_azcli.ps1 @@ -154,7 +154,7 @@ $output = az deployment group create --resource-group $ResourceGroupName --templ if (!$output) { Write-Error "Error creating SqlVM"; return; -} +} $SQLVM|Out-String|Log-Output; Log-Output 'DONE: Applying SqlVM Config' diff --git a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep index ea625831b..d5dc5cc69 100644 --- a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep +++ b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep @@ -2,11 +2,11 @@ param sqlConnectivityType string = 'Public' param sqlPortNumber int = 41433 param sqlStorageWorkloadType string = 'General' param sqlStorageDisksConfigurationType string = 'NEW' -param sqlDataSettingsDefaultFilePath string = 'F:\\SQLData' +param sqlDataSettingsDefaultFilePath string = 'D:/SQLData' param sqlDataSettingsLUNs array = array(0) -param sqlLogSettingsDefaultFilePath string = 'G:\\SQLData' +param sqlLogSettingsDefaultFilePath string = 'C:\\SQLData' param sqlLogSettingsLUNs array = array(1) -param sqlTempDbSettingsDefaultFilePath string = 'H:\\SQLData' +param sqlTempDbSettingsDefaultFilePath string = 'C:\\SQLData' param sqlAutopatchingDayOfWeek string = 'Sunday' param sqlAutopatchingStartHour int = 2 param sqlAutopatchingWindowDuration int = 60 @@ -34,17 +34,17 @@ resource newVMName_resource 'Microsoft.SqlVirtualMachine/SqlVirtualMachines@2017 } storageConfigurationSettings: { diskConfigurationType: sqlStorageDisksConfigurationType - sqlDataSettings : { - luns: sqlDataSettingsLUNs - defaultFilePath: sqlDataSettingsDefaultFilePath - } - sqlLogSettings: { - luns: sqlLogSettingsLUNs - defaultFilePath: sqlLogSettingsDefaultFilePath - } - sqlTempDbSettings: { - defaultFilePath: sqlTempDbSettingsDefaultFilePath - } + // sqlDataSettings : { + // luns: sqlDataSettingsLUNs + // defaultFilePath: sqlDataSettingsDefaultFilePath + // } + // sqlLogSettings: { + // luns: sqlLogSettingsLUNs + // // defaultFilePath: sqlLogSettingsDefaultFilePath + // } + // sqlTempDbSettings: { + // // defaultFilePath: sqlTempDbSettingsDefaultFilePath + // } storageWorkloadType: sqlStorageWorkloadType } serverConfigurationsManagementSettings: { From b93c087aaae53dc3ab502fbf16517069a30e1da0 Mon Sep 17 00:00:00 2001 From: Liz Baron <10554+lizbaron@users.noreply.github.com> Date: Wed, 22 Dec 2021 19:02:38 -0500 Subject: [PATCH 06/10] Add a data disk to the vm, because we seem to get an error for Log and Data filepaths otherwise. --- CI/Azure-DevOps/CreateSQLVM_azcli.ps1 | 2 +- .../CreateSqlVirtualMachineTemplate.bicep | 32 +++++++++---------- 2 files changed, 17 insertions(+), 17 deletions(-) diff --git a/CI/Azure-DevOps/CreateSQLVM_azcli.ps1 b/CI/Azure-DevOps/CreateSQLVM_azcli.ps1 index dcc66febc..3eff8837d 100644 --- a/CI/Azure-DevOps/CreateSQLVM_azcli.ps1 +++ b/CI/Azure-DevOps/CreateSQLVM_azcli.ps1 @@ -129,7 +129,7 @@ Log-Output "Creating VM $VMName"; $output = az vm create --name "$VMName" --resource-group "$ResourceGroupName" --location "$Location" --admin-password "$VMAdminPwd" ` --admin-username "$VMAdminName" --computer-name "$VMName" --image "$ImageUrn" --nics "$InterfaceName" --priority Spot ` - --size $Size | ConvertFrom-Json; + --size $Size --data-disk-sizes-gb 8 | ConvertFrom-Json; if (!$output) { Log-Output "VMName: ", $VMName; Log-Output "ResourceGroupName: ", $ResourceGroupName; diff --git a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep index d5dc5cc69..3bcd13852 100644 --- a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep +++ b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep @@ -2,11 +2,14 @@ param sqlConnectivityType string = 'Public' param sqlPortNumber int = 41433 param sqlStorageWorkloadType string = 'General' param sqlStorageDisksConfigurationType string = 'NEW' -param sqlDataSettingsDefaultFilePath string = 'D:/SQLData' -param sqlDataSettingsLUNs array = array(0) -param sqlLogSettingsDefaultFilePath string = 'C:\\SQLData' -param sqlLogSettingsLUNs array = array(1) -param sqlTempDbSettingsDefaultFilePath string = 'C:\\SQLData' +param sqlDataSettingsDefaultFilePath string = 'F:\\data' +param sqlDataSettingsLUNs array = [ + 0 +] +param sqlLogSettingsDefaultFilePath string = 'F:\\log' +param sqlLogSettingsLUNs array = [ + 0 +] param sqlAutopatchingDayOfWeek string = 'Sunday' param sqlAutopatchingStartHour int = 2 param sqlAutopatchingWindowDuration int = 60 @@ -34,17 +37,14 @@ resource newVMName_resource 'Microsoft.SqlVirtualMachine/SqlVirtualMachines@2017 } storageConfigurationSettings: { diskConfigurationType: sqlStorageDisksConfigurationType - // sqlDataSettings : { - // luns: sqlDataSettingsLUNs - // defaultFilePath: sqlDataSettingsDefaultFilePath - // } - // sqlLogSettings: { - // luns: sqlLogSettingsLUNs - // // defaultFilePath: sqlLogSettingsDefaultFilePath - // } - // sqlTempDbSettings: { - // // defaultFilePath: sqlTempDbSettingsDefaultFilePath - // } + sqlDataSettings : { + luns: sqlDataSettingsLUNs + defaultFilePath: sqlDataSettingsDefaultFilePath + } + sqlLogSettings: { + luns: sqlLogSettingsLUNs + defaultFilePath: sqlLogSettingsDefaultFilePath + } storageWorkloadType: sqlStorageWorkloadType } serverConfigurationsManagementSettings: { From 07008705454f652e974f37b6786ba26cdf2a7b49 Mon Sep 17 00:00:00 2001 From: Liz Baron <10554+lizbaron@users.noreply.github.com> Date: Thu, 23 Dec 2021 05:51:14 -0500 Subject: [PATCH 07/10] can we do this without luns? --- CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep index 3bcd13852..c14b9dabb 100644 --- a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep +++ b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep @@ -2,13 +2,13 @@ param sqlConnectivityType string = 'Public' param sqlPortNumber int = 41433 param sqlStorageWorkloadType string = 'General' param sqlStorageDisksConfigurationType string = 'NEW' -param sqlDataSettingsDefaultFilePath string = 'F:\\data' +param sqlDataSettingsDefaultFilePath string = '~\\data' param sqlDataSettingsLUNs array = [ - 0 + ] -param sqlLogSettingsDefaultFilePath string = 'F:\\log' +param sqlLogSettingsDefaultFilePath string = '~\\log' param sqlLogSettingsLUNs array = [ - 0 + ] param sqlAutopatchingDayOfWeek string = 'Sunday' param sqlAutopatchingStartHour int = 2 From 5e26a8e9fca6f379418b4f4c8ee0b5e9efb2dc99 Mon Sep 17 00:00:00 2001 From: Liz Baron <10554+lizbaron@users.noreply.github.com> Date: Thu, 23 Dec 2021 06:00:08 -0500 Subject: [PATCH 08/10] that didn't work, let's try something else --- CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep index c14b9dabb..f79f240bc 100644 --- a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep +++ b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep @@ -2,11 +2,11 @@ param sqlConnectivityType string = 'Public' param sqlPortNumber int = 41433 param sqlStorageWorkloadType string = 'General' param sqlStorageDisksConfigurationType string = 'NEW' -param sqlDataSettingsDefaultFilePath string = '~\\data' +param sqlDataSettingsDefaultFilePath string = 'c:\\data' param sqlDataSettingsLUNs array = [ ] -param sqlLogSettingsDefaultFilePath string = '~\\log' +param sqlLogSettingsDefaultFilePath string = 'c:\\log' param sqlLogSettingsLUNs array = [ ] From c158991de29eb3b9d5f467bbcc17b1dbb61e1a5a Mon Sep 17 00:00:00 2001 From: Liz Baron <10554+lizbaron@users.noreply.github.com> Date: Thu, 23 Dec 2021 06:07:46 -0500 Subject: [PATCH 09/10] What will happen if I specify a LUN=0 but use C drive??? --- CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep index f79f240bc..fed007afa 100644 --- a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep +++ b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep @@ -4,11 +4,11 @@ param sqlStorageWorkloadType string = 'General' param sqlStorageDisksConfigurationType string = 'NEW' param sqlDataSettingsDefaultFilePath string = 'c:\\data' param sqlDataSettingsLUNs array = [ - + 0 ] param sqlLogSettingsDefaultFilePath string = 'c:\\log' param sqlLogSettingsLUNs array = [ - + 0 ] param sqlAutopatchingDayOfWeek string = 'Sunday' param sqlAutopatchingStartHour int = 2 From 0d2949c08efe71a0e6e84e79d674a4d6eb80d216 Mon Sep 17 00:00:00 2001 From: Liz Baron <10554+lizbaron@users.noreply.github.com> Date: Thu, 23 Dec 2021 06:17:43 -0500 Subject: [PATCH 10/10] going back to the last working version --- CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep index fed007afa..3bcd13852 100644 --- a/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep +++ b/CI/Azure-DevOps/CreateSqlVirtualMachineTemplate.bicep @@ -2,11 +2,11 @@ param sqlConnectivityType string = 'Public' param sqlPortNumber int = 41433 param sqlStorageWorkloadType string = 'General' param sqlStorageDisksConfigurationType string = 'NEW' -param sqlDataSettingsDefaultFilePath string = 'c:\\data' +param sqlDataSettingsDefaultFilePath string = 'F:\\data' param sqlDataSettingsLUNs array = [ 0 ] -param sqlLogSettingsDefaultFilePath string = 'c:\\log' +param sqlLogSettingsDefaultFilePath string = 'F:\\log' param sqlLogSettingsLUNs array = [ 0 ]