D45 patch what you can do #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jz-huang
approved these changes
Oct 11, 2018
Contributor
jz-huang
left a comment
jz-huang
left a comment
There was a problem hiding this comment.
I left a comment on the old review.. it's not part of your current changes so it's not blocking.
andyvadul
added a commit
to andyvadul/extensions-api
that referenced
this pull request
Oct 13, 2018
D45 patch what you can do (tableau#161)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making the same change to master that we made to the dev branch.
This one just adds the "what you can do list" to the overview topic.
@jz-huang @Kovner