Skip to content

Conversation

@brtal
Copy link
Contributor

@brtal brtal commented Aug 9, 2019

No description provided.

nikhillakshman and others added 9 commits April 19, 2019 14:06
* Update readme.md (#152)

Fixed typo of the word 'extension' in third sentence.

* Update trex_configure.md (#156)

Fixed JavaScript typo found by @jakkyn

* Update trex_getstarted.md (#157)

Fixed error found by @jakkyn - In the Choose dialog box, the Choose button is now My Extensions.

* Update trex_overview.md (#160)

Added the "what you can do list" to the overview page

* Doc update to add design guidelines, tableau UI links, and localhost info (#165)

Adding the doc updates for TC18 (Design Guidelines, Tableau UI link).

* Update trex_security.md

adding a comma to help fix a weird sentence.

* Update datasource.html (#170)

* Update datasource.html

This patch is temporary and will be superseded when we update the reference pages. 
This patch updates DataSourceInterfaces.ts  - adding a note to explain that refreshAsync() should not be used to automatically refresh the viz, and that doing so on Tableau Online might result in the removal of the extension.

* Update datasource.html

refined note with John's suggestion (blocked vs. removal)

* Doc updates for 2018.3  (#178)

* updated docs for debugging, error handling, getting started, creating first extension

* Updated debugging gifs, minor doc updates

* Image used for the Extensions API Reference pages

* Fixed typos

* Fixing broken link

* Fixed broken link to error codes topic

* fixed typo

* More tech review updates and CX editorial fixes

* Added Keshia's allow/deny flowchart; more CX edits

* Update trex_publish.md

Adding a note that hosting extensions on Tableau Server is not recommended.

* Update trex_debugging.md

* Update trex_publish.md

Refining the message that the web server needs to be on a different computer than the one running Tableau Server.

* Update trex_publish.md

Removed "the" from "the Tableau Server or Tableau Online."

* Update trex_publish.md

Changed the wording about hosting extensions on Tableau Server back to what it was before the last commit (as not recommended).

* Doc updates for 2019.1 and v1.2 library; show-hide, chromium, API syn… (#195)

* Doc updates for 2019.1 and v1.2 library; show-hide, chromium, API sync fix, best practices

* removed best practices, changed to 1.1, modified visbility-error workaround

* correcting version number to 1.1

* fixing library 1.1 references; drop-down menu fix

* Update ux_controls_ui_patterns.md (#199)

Adding a heading to a column in a table. The Markdown looked fine, but Jekyll didn't recognize it as a table without a heading to the column.

* Fixing missing .gif file

Added the .gif file with the correct name. The previous file name had a `(`` instead of an `_`.

* Delete 3-Small)on_Dark_Background.gif

Had a typo in the file name. Added the file with the correct name.

* Release 1.1.0

* [Security] Fix DOM XSS vulnerability in search

* Update trex_examples.md (#203)

fixed broken link (typo in path) to getting started topic

* Release 1.2

* updating release notes for the version 1.2 library (#214)

* Updating documentation for version 1.2 of the library

* Renaming library files to new naming format

* updated the library file name with new convention; removed page visibilit (#222)

* Nlakshman/library reference (#221)

* The format of the extension library name has changed from tableau-extensions-n.n.n.js to tableau.extensions.n.n.n.js . Updating the references in your samples, tutorials and docs.

* Reverting the format of older versions

* updated the library file name with new convention; removed page visibilit (#222)

* The format of the extension library name has changed from tableau-extensions-n.n.n.js to tableau.extensions.n.n.n.js . Updating the references in your samples, tutorials and docs.

* Reverting the format of older versions

* Update trex_security.md (#224)

changing the lib version to reference the `1.latest`
Copy link
Contributor

@ashwinar ashwinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks more like an existing issue. If I load the Filtering sample, For the range filter when I change the filter, In the Current Values section I see min for both, should be max:
min: 1/3/2014, min: 12/30/2017.

Also, verified loading all the typescript samples on desktop and it looks good. I didn't go every single enum/interface html, but did random sanity checks and they look good. I must say, our docs looks way more clean now. Also, I couldn't verify clicking the "Inherited" option in the docs, guess I'd see that only after it gets published to Pages.

@brtal
Copy link
Contributor Author

brtal commented Aug 10, 2019

In terms of the filtering sample, I've opened an internal issue for this.

@brtal brtal merged commit ab99a0d into dev Aug 10, 2019
@bcantoni bcantoni deleted the add_typescript branch January 13, 2022 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants