-
Notifications
You must be signed in to change notification settings - Fork 261
TFSID:1362792 VizAPI custom title field; Tableau Exchange changes, misc edits #465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
docs/trex_getstarted.md
Outdated
| ### Start Tableau and add an extension to the dashboard | ||
|
|
||
| 1. Start Tableau and open a workbook that has a dashboard, or open a workbook and create a new dashboard. | ||
| 1. Start Tableau and open a workbook that has a dashboard, or open a workbook and create a new dashboard with at least one worksheet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we saying it needs to have a worksheet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bcantoni had that comment/change in his PR, so I kept it. On the other hand, we tell them to use the Datasources sample, so we should probably say open a Superstore workbook, or a workbook that has a data source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. I changed this to say:
"Start Tableau and open a workbook that has a dashboard, or open a workbook and create a new dashboard. For example, you could use one of the Tableau sample workbooks like Superstore to start with."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this wording sounds good. My original "with at least one worksheet" didn't make much sense, but what I intended here was to suggest they use a dashboard with something on it. We instruct people to use the Samples/DataSources.trex extension, but it won't have anything to report if used on a new empty dashboard.
docs/trex_create.md
Outdated
|
|
||
| 2. Start Tableau and open a workbook with a dashboard or create a new dashboard. | ||
| 3. In the dashboard, under **Objects**, select **Extension** and drag it on to the dashboard. In the **Choose an Extension** dialog box, click **My Extensions** and browse to directory where you have your manifest file. | ||
| 2. Start Tableau and open a workbook with a dashboard, or create a new dashboard with at least one worksheet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnDance @bcantoni same story here. We probably don't need to say "with at least one worksheet" When you open a new workbook, it automatically creates a worksheet. In this example, where we just get the name of the dashboard, it doesn't matter if it's blank.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, having it in there makes it sound like a requirement. While most extensions need a worksheet, it isn't a requirement.
By the way, I only tagged one of these statement. There was at least 1 above here, or maybe two.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@johnDance Correct. There were two places where I added the "with at least one worksheet." I've removed that from both. In this case (trex_create.md), I just left it the way it was "open a workbook with a dashboard, or create an new dashboard.."
… into d45_docs_vizApiBugfix
In this pull request:
projectfrelard, Readme.md, and misc broken links and typos.