Skip to content

Conversation

@bcantoni
Copy link
Contributor

@bcantoni bcantoni commented Mar 3, 2022

No description provided.

@bcantoni bcantoni changed the base branch from main to dev March 3, 2022 01:04
@elbandito
Copy link
Contributor

@bcantoni I know this is a WIP, but having the dev branch may cause problems, because most times the package-lock.json file points to artifactory and will cause timeout errors during Github Action builds.

@bcantoni bcantoni changed the base branch from dev to main March 3, 2022 01:48
@bcantoni
Copy link
Contributor Author

bcantoni commented Mar 3, 2022

@elbandito thanks I forgot about that! I'll swap it back to go against main. There does seem to be failures on Windows in that line running tslint.

@bcantoni bcantoni changed the title WIP: Expand actions to work on all 3 OS and PRs off dev branch Improve support for developing on Windows Mar 3, 2022
@bcantoni
Copy link
Contributor Author

bcantoni commented Mar 3, 2022

This change includes a couple things that might help for those who are developing on Windows:

  • Update the build action to also run on Mac and Windows (currently only on Linux)
  • Switch the tslint command to use npx rather than a local path

Without that second fix, the Windows action runs were failing with:

> extensions-api-sdk@1.8.1 tslint
> ./node_modules/.bin/tslint --config ./tslint.json ./Samples-Typescript/*/*.ts*

'.' is not recognized as an internal or external command,
operable program or batch file.

@bcantoni bcantoni merged commit de3316d into main Mar 3, 2022
@bcantoni bcantoni deleted the expand-actions branch March 3, 2022 22:01
garudolph added a commit to garudolph/extensions-api that referenced this pull request Apr 1, 2022
stephendeoca pushed a commit that referenced this pull request Jun 24, 2022
* Expand actions to run on Mac + Win in addition to Linux
* Switch to cross-platform way to call tslint
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants