Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to normalize 7 #377

Closed
feross opened this issue May 11, 2017 · 9 comments
Closed

Update to normalize 7 #377

feross opened this issue May 11, 2017 · 9 comments

Comments

@feross
Copy link
Contributor

feross commented May 11, 2017

Many of the changes introduced by Normalize 6 were disruptive. The project maintainer now believes that to have been a mistake. Normalize 7 has reverted those changes. (There's a long issue thread about the reasons here: necolas/normalize.css#664)

This commit shows what changed in Normalize 7: necolas/normalize.css@b4a8fda

Can we update to Normalize 7?

@khakulov
Copy link

khakulov commented May 11, 2017

+1 #374

Actual version of Tachyons is not usable.

@johnotander @mrmrs

@mrmrs
Copy link
Member

mrmrs commented May 11, 2017 via email

@khakulov
Copy link

@mrmrs because tachyons using broken normalize version.

It broke my body element, because of removed margin: 0
Buttons text looks smaller so broke my UI

@YerkoPalma
Copy link

Same as @khakulov here, just updated to tachyons@4.7.2 and my project was broken because of the margin in body and some font reset...
Anyway, I wouldn't say that is not usable, but is quite more difficult.

@sircharleswatson
Copy link

You can always add normalize yourself until the Tachyons one is updated.

dashed added a commit to dashed/tachyons that referenced this issue May 13, 2017
@cwonrails
Copy link
Contributor

cwonrails commented May 17, 2017

I did a git rebase -i and updated normalize.css 7.0.0 then reran the build process. Here's the PR #374

@winkerVSbecks
Copy link

This is possibly related to normalize… body { margin: 0 } is missing from tachyons since v4.7.2. But, normalize 7.0 seems to have it.

@wKovacs64
Copy link

Resolved as of #384 and Tachyons v4.7.4.

@johno
Copy link
Member

johno commented May 22, 2017

Yep, this has been resolved in our latest version. Let us know if you encounter any other issues, thanks for opening!

@johno johno closed this as completed May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants