New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bailout on missing 'plackup' #7

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@garu
Collaborator

garu commented Nov 28, 2015

Hello! Me again :)

As promised, this is an alternative approach to #6. What I did here was bail out of the tests if no plackup binary is found by File::Which (instead of what I did in #6 which is defaulting to "plackup" which most likely will still fail).

While the issue itself is still not fixed (I don't think finding 'plackup' is the proper solution and I think we instead should use Plack::Runner directly, even via perl -e, as per the discussion in #6), the failing tests will do so with a much more informative message, including a dump of the PATH environment variable and extra information on how to fix the issue (in case it's a human and not a smoking box) by setting the environment properly.

It also fixes an ongoing issue where UBIC_SERVICE_PLACKUP_BIN was always being replaced during testing, so the only way to make tests pass would be to actually change the PATH to include the parent dir for plackup (wherever it was). Now the user can simply set UBIC_SERVICE_PLACKUP_BIN and the tests will find it!

I think this approach is better than the one in #6. If you agree, feel free to merge this and close the other. Otherwise, let me know if there's anything I can do to help :)

Cheers!

@berekuk

This comment has been minimized.

Collaborator

berekuk commented Dec 28, 2015

@tadam, since it looks like neither you nor me have time for these PRs, let's maybe just give @garu a commit bit?

@tadam

This comment has been minimized.

Owner

tadam commented Jan 18, 2016

@berekuk I'd love to give away all the repos that I have. Do you know someone who could pick them up?

@garu Would you like to be the maintainer of this module?

@berekuk

This comment has been minimized.

Collaborator

berekuk commented Jan 18, 2016

@tadam, I've been meaning to write "goodbye" blog post on blogs.perl.org for some time and ask for volunteers, but haven't got to this yet.

@garu

This comment has been minimized.

Collaborator

garu commented Jan 18, 2016

Hi guys! While I don't mind a commit bit, I hardly thing I'm the best person for the task. Ubic is a very interesting tool with a big community afaik, and I don't think I'll have enough time to give it the attention it deserves in the foreseeable future. I'm sure there are people in the Ubic community which are (or can be) much more invested in it :)

@tadam

This comment has been minimized.

Owner

tadam commented Jan 18, 2016

@garu I gave a commit bit and you're a co-maintainer of this module on CPAN now. You can do whatever you want =)
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment