-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Take care uppercase when input words #30
Comments
I read the source code, and will make a PR for this :) |
Thank you for creating a issue! I'm looking forward to your PR 💚 And, I'm going to release v3.0.0 this weekend, so it would be next week at the earliest to release that includes your PR. |
@chenyukang It probably works as you expected. |
Yes, it works like a charm! Awesome 🙌 But I can feel it a little bit slower when typing. I can image if we can use some algorithm like bucket sort will make it much quicker, split the list into 26 sub list according first character, and iterate the sub list only. |
Would you tell me the number of your words? ( this ? )
If everything works well after releasing v3.0.0 (which means nobody wants to partial match), I want to try it 👍 |
yes
Nice, for prefix-matching trie tree is also efficient, but need a little bit more coding that sorting. |
This VScode plugin is similar, you may have a reference 😏 |
@chenyukang Would you show me console logs on Developer Tools? |
Thanks. Surely, it is too slow.. |
I think a hotkey or shortcut to toggle complementation will also useful, 😏 |
I think it's not because my PC is not powerful. The time cost also related to the Obsidian contents. Instead of in one iteration, handling internal link, alias, dictionary complementation separately may help. |
According discussion in #29.
For instance, we have 'banana' in dictionary, if I type this word in the beginning of a sentence, I will type "Ba", but it will not complete currently,
I guess ignore uppercase will be better. If "Banana" is in candidate list will be perfect.
The text was updated successfully, but these errors were encountered: