#10: Support post removal #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this solves #10 |
|
тесты упали: |
tadatuta
requested changes
Mar 25, 2017
| content: [ | ||
| { | ||
| block: 'button', | ||
| text: i18n(this.block, 'Delete'), |
There was a problem hiding this comment.
по негласной договоренности порядок ключей: block, mods, mix, text
| }, | ||
| { | ||
| block: 'modal', | ||
| mods: { theme: 'islands', autoclosable: true, visible: false }, |
There was a problem hiding this comment.
модификатор в значении false не имеет смысла
| @@ -11,6 +13,51 @@ block('issue').content()(function() { | |||
| elem: 'date', | |||
| content: issue.created_from_now | |||
| }, | |||
| issue.user.login === currentUser.login && { | |||
| block: 'issue', | |||
There was a problem hiding this comment.
здесь и везде ниже вместо хардкода имени блока использовать this.block (можно закешировать заранее)
| mods: { theme: 'islands', size: 'm', view: 'action' }, | ||
| mix: { block: 'issue', elem: 'delete-modal-yes' }, | ||
| text: i18n(this.block, 'DeleteYes'), | ||
| js: { number: issue.number } |
| }, | ||
| { | ||
| block: 'spin', | ||
| mods: { theme: 'islands', size: 'm', visible: false }, |
| _onClickDeleteButton: function(event) { | ||
| var modal = this._elem('delete-confirm-modal').findMixedBlock(Modal); | ||
|
|
||
| event.preventDefault(); |
There was a problem hiding this comment.
какую задачу здесь решает preventDefault?
| var modal = this._elem('delete-confirm-modal').findMixedBlock(Modal); | ||
|
|
||
| event.preventDefault(); | ||
| modal.setMod('visible', true); |
| $.post('/api/' + event.bemTarget.params.number + '/delete', { | ||
| token: '213123123' | ||
| }).then(function(response) { | ||
| if (response === 'ok') { |
| } | ||
| }).catch(function(){ | ||
| spinner.delMod('visible'); | ||
| modalBody.setMod('visible', true); |
There was a problem hiding this comment.
тут бы какое-то пояснение для пользователя, что ничего такого не случилось
| // deleting issue with 'removed' label | ||
| var issueAddLabelRequestUrl = applyToken(issuesRequestUrl + '/' + req.params.id + '/labels', req.body.token); | ||
|
|
||
| makeIssueRemoveRequest(issueAddLabelRequestUrl).then(function() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@skad0 @tadatuta