Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move use #14

Merged
merged 2 commits into from Dec 8, 2015
Merged

Move use #14

merged 2 commits into from Dec 8, 2015

Conversation

jonathanstowe
Copy link
Contributor

For some reason with some very recent changes to rakudo we get:

t/trait.t ...... ===SORRY!=== Error while compiling /home/jonathan/devel/perl6/modules/JSON-Unmarshal/t/trait.t
Can't use unknown trait 'is unmarshalled-by' in an attribute declaration.
at /home/jonathan/devel/perl6/modules/JSON-Unmarshal/t/trait.t:8
    expecting any of:
        rw
        readonly
        box_target
        leading_docs
        trailing_docs

It seems having the JSON::Name used in the same scope that the other traits are defined, hides those traits. Very odd.

I also added a .gitignore as a .precomp directory comes free with every execution :)

Seems that something recent caused this to hide the traits
@tadzik
Copy link
Owner

tadzik commented Dec 1, 2015

Is it a rakudobug we should report before fixing this on our side? :)

@jonathanstowe
Copy link
Contributor Author

It's precomp fallout, I'm not entirely sure why it is doing it, I guess a quick rakudobug just to check wouldn't hurt ;-)

@jonathanstowe
Copy link
Contributor Author

I RT'd this with https://rt.perl.org/Ticket/Display.html?id=126804 but I think that the change should probably go in anyway pending someone actually making a call on whether it is a bug or not.

@jonathanstowe
Copy link
Contributor Author

Hi,
I'd actually forgotten that JSON::Unmarshal is depended on by META6 which in term is depended on by Test::META which in turn is being used by a bunch of other modules, which can't be installed right now (without using notests,) so it would be really, really cool if you could merge this now, with a view to reverting it later if and when the above RT gets fixed.

tadzik pushed a commit that referenced this pull request Dec 8, 2015
@tadzik tadzik merged commit ec7bc5c into tadzik:master Dec 8, 2015
@tadzik
Copy link
Owner

tadzik commented Dec 8, 2015

Yeah, sorry, totally forgot about this. Thanks for the patch and for reminding me!

@jonathanstowe
Copy link
Contributor Author

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants