Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to specify a particular commit in URLs #131

Merged
merged 2 commits into from Apr 13, 2015

Conversation

perlpilot
Copy link
Contributor

Since the HEAD of a repo may be where development happens and a
particular tag or commit will correspond to a particular version of a
module, allow URLS of the form git://github.com/foo/bar@v1.2.3
to checkout the commit specified by "v1.2.3" once the repo is cloned.

Since the HEAD of a repo may be where development happens and a
particular tag or commit will correspond to a particular version of a
module, allow URLS of the form  git://github.com/foo/bar@v1.2.3
to checkout the commit specified by "v1.2.3" once the repo is cloned.
@@ -34,9 +36,13 @@ method fetch($from, $to) {
return True;
}

sub git-fetch($from, $to) {
sub git-fetch($from, $to, $commit = Nil) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather see $commit? here, Nil just makes me thing "why a do you want a list here?"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I updated the branch

@tadzik
Copy link
Owner

tadzik commented Apr 13, 2015

Awesome! Thanks a lot.

tadzik pushed a commit that referenced this pull request Apr 13, 2015
Add a way to specify a particular commit in URLs
@tadzik tadzik merged commit ee1d81b into tadzik:master Apr 13, 2015
tadzik pushed a commit that referenced this pull request Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants