Somewhat repaired gen-meta #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somewhere along the line it was trying to pass "$*EXECUTABLE -MPanda::DepTracker" to Proc::Async.new
around as suggested by FROGGS
|
Can you tell me what is it about gen-meta that needs repairing? I haven't looked at that part of panda code in a while, and I don't really know what's going on in there :) |
|
We relied on the fact that subprocesses are invoked via a shell. Now we're using Proc::Async which works more like run(), and therefore we cannot inject args anymore in the way we did it. |
|
Yeah, specifically the Bundler.bundle altererd $*EXECUTABLE by appending the " -MPanda::Deptracker" to alter that for the build and test, this no longer works (it probably needs a test case but hey) The patch rectifies this. |
|
I'm going to redo this from scratch as the other changes have made it tricky. I'll close and do another one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhere along the line it was trying to pass "$*EXECUTABLE -MPanda::DepTracker" to Proc::Async.new when building as part of "gen-meta" . This clearly doesn't work.
This adds a new named param to build so that the DepTracker can be added when required.
I may have to add this in a number of places at it seems to depend on the previous behaviour of setting $*EXECUTABLE with the '-M' all over the place.