Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make File:Find recursive optional #4

Merged
merged 2 commits into from Mar 7, 2013
Merged

make File:Find recursive optional #4

merged 2 commits into from Mar 7, 2013

Conversation

cnd
Copy link
Contributor

@cnd cnd commented Mar 7, 2013

No description provided.

@tadzik
Copy link
Owner

tadzik commented Mar 7, 2013

The patch looks good. Could you add some simple test too?

@cnd
Copy link
Contributor Author

cnd commented Mar 7, 2013

yes, wait a second

@cnd
Copy link
Contributor Author

cnd commented Mar 7, 2013

>>make test   
~/contrib/perl6-File-Tools/ :)
make: Circular blib/lib/File/Find.pir <- blib/lib/File/Find.pir dependency dropped.
env PERL6LIB=/home/nen/contrib/perl6-File-Tools/blib/lib:/home/nen/contrib/perl6-File-Tools/lib: prove -e 'perl6' -r t/
t/01-file-find.t ...... ok   
t/02-shell-command.t .. ok     
All tests successful.
Files=2, Tests=18,  3 wallclock secs ( 0.04 usr  0.01 sys +  2.84 cusr  0.20 csys =  3.09 CPU)
Result: PASS

tadzik pushed a commit that referenced this pull request Mar 7, 2013
make File:Find recursive optional
@tadzik tadzik merged commit a8131ae into tadzik:master Mar 7, 2013
@tadzik
Copy link
Owner

tadzik commented Mar 7, 2013

Awesome, thanks!

@cnd
Copy link
Contributor Author

cnd commented Mar 7, 2013

I think that perl now is my yet another favorite language. Sad that I emerged it for myself so late...

People were saying it's scary and ugly read-only language but I find it much more clear than python...

@tadzik
Copy link
Owner

tadzik commented Mar 7, 2013

Better late than never; welcome aboard :)

Readability is a subjective matter for one thing, but what really matters is how the code is written, not in which language.

I've set up a challenge in a local LUG some time ago, that I'm buying a beer for anyone who'll be able to find truly unreadable Perl code on my github. Few tried (pythoners especially), but the challenge is still open, for what it's worth :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants