Make git handling more robust (Closes #21) #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a previous build was with a tag or a specific revision, the git repo ends up with a detached HEAD, and that makes "git pulL" fail. Instead test if origin/$rev exists, and if yes, check that one out
that way the line number of failed external programs points to the caller of run()
if the configure stage was aborted, some Makefile targets might be missing, causing a "make realclean" to fail
If you forget the backend, but pass a revision to build, the error message now makes it very clear that you forgot to specify the backend
tadzik
pushed a commit
that referenced
this pull request
Feb 1, 2015
Make git handling more robust (Closes #21)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use "git fetch" + "git checkout" instead of "git pull", because "pull" fails on detached HEADs.
Also includes a bit of unrelated robustness improvements.