try to match panda's version to the current rakudo #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! First of all let me thank you for rakudobrew: it's a great tool and the one thing I missed to start really digging into perl 6!
It got my attention that, when installing panda via
build-pandaorbuild panda, rakudobrew was not taking into account whether panda had a matching version for the rakudo it was built for. As a result, it was doing weird things like installing panda HEAD for a very old rakudo build (like pre v6.c).This is a simple patch that attempts to fix this issue. It works the following way:
If the user has provided a version for panda (e.g. "
rakudobrew build-panda 2016.01") then it honors said version and croaks if it can't find it.However, if the user has NOT provided a version for panda (e.g. "
rakudobrew build-panda") then it first tries to checkout a panda version that matches the current rakudo version being used. If it can't find a match, it fallbacks to panda's HEAD (with a mention on the logs). The user can still update its panda by simply doing a "rakudobrew build-panda HEAD".I think this might help people trying to work with many different rakudo versions. It's specially interesting for Travis-CI, where you can now write on the
installsection:instead of:
Hope this is helpful! And thanks again for all the great work in rakudobrew :)
Cheers!