allow synbot6 to respond to >1 item per utterance #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does this by setting up a grammar, parsing out the interesting bits, and responding to them in action methods. The code that this replaces not only latches on to the first thing it sees, it also *returns early* (not considering later things) if the first thing turned out to be uninteresting. This version does not do that. After some consideration, I decided that the grammar rules should do as little as possible. Just the parsing. The actions then get to decide whether the parsed-out item deserves a reaction of some sort. Yes, the actions class is nested inside of the `said` method. This is the easiest way for it to get privileged access to the method parameter `$e`.
|
Awesome :) |
tadzik
pushed a commit
that referenced
this pull request
May 9, 2015
allow synbot6 to respond to >1 item per utterance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It does this by setting up a grammar, parsing out the interesting bits, and responding to them in action methods.
The code that this replaces not only latches on to the first thing it sees, it also returns early (not considering
later things) if the first thing turned out to be uninteresting. This version does not do that.
After some consideration, I decided that the grammar rules should do as little as possible. Just the parsing.
The actions then get to decide whether the parsed-out item deserves a reaction of some sort.
Yes, the actions class is nested inside of the
saidmethod. This is the easiest way for itto get privileged access to the method parameter
$e.An earlier version of this PR did something silly with dynamic variables. But that's fixed now.
arnsholt++ for suggesting the fix.