Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding feature breaks API #180

Closed
stbuehler opened this issue Dec 25, 2019 · 1 comment · Fixed by #399
Closed

encoding feature breaks API #180

stbuehler opened this issue Dec 25, 2019 · 1 comment · Fixed by #399
Labels
encoding Issues related to support of various encodings of the XML documents

Comments

@stbuehler
Copy link

Hi,

the way features work in cargo is that any crate in your dependency tree can enable additional features for its dependencies, and each dependency ("crate") is only compiled once with all features merged; thus they must only add additional "APIs" without breaking what was before.

I.e. enabling the encoding feature should provide new structs and functions (or just improve existing ones without changing their signature).

Also the reader::Decoder struct is not public and not documented, but Reader::decoder() is... I guess either both or none should be public.

@tafia
Copy link
Owner

tafia commented Feb 1, 2020

You are right, this is an oversight on my side.

@Mingun Mingun added the encoding Issues related to support of various encodings of the XML documents label May 21, 2022
Mingun added a commit to Mingun/quick-xml that referenced this issue Jun 19, 2022
The method `Reader::decoder()` is public anyway, but its result type is not, which means
that it cannot be used as method argument, and that is not good
Mingun added a commit to Mingun/quick-xml that referenced this issue Jun 19, 2022
Mingun added a commit to Mingun/quick-xml that referenced this issue Jun 19, 2022
The method `Reader::decoder()` is public anyway, but its result type is not, which means
that it cannot be used as method argument, and that is not good
Mingun added a commit to Mingun/quick-xml that referenced this issue Jun 19, 2022
Mingun added a commit to Mingun/quick-xml that referenced this issue Jun 20, 2022
Mingun added a commit to Mingun/quick-xml that referenced this issue Jun 20, 2022
…ature `encoding` enabled and when it is disabled

Co-authored-by: Daniel Alley <dalley@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
encoding Issues related to support of various encodings of the XML documents
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants