New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
encoding feature breaks API #180
Labels
encoding
Issues related to support of various encodings of the XML documents
Comments
You are right, this is an oversight on my side. |
Mingun
added a commit
to Mingun/quick-xml
that referenced
this issue
Jun 19, 2022
The method `Reader::decoder()` is public anyway, but its result type is not, which means that it cannot be used as method argument, and that is not good
Mingun
added a commit
to Mingun/quick-xml
that referenced
this issue
Jun 19, 2022
…ding` is defined or not
Mingun
added a commit
to Mingun/quick-xml
that referenced
this issue
Jun 19, 2022
The method `Reader::decoder()` is public anyway, but its result type is not, which means that it cannot be used as method argument, and that is not good
Mingun
added a commit
to Mingun/quick-xml
that referenced
this issue
Jun 19, 2022
…ding` is defined or not
Mingun
added a commit
to Mingun/quick-xml
that referenced
this issue
Jun 20, 2022
…ding` is defined or not
Mingun
added a commit
to Mingun/quick-xml
that referenced
this issue
Jun 20, 2022
…ature `encoding` enabled and when it is disabled Co-authored-by: Daniel Alley <dalley@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
the way features work in cargo is that any crate in your dependency tree can enable additional features for its dependencies, and each dependency ("crate") is only compiled once with all features merged; thus they must only add additional "APIs" without breaking what was before.
I.e. enabling the
encoding
feature should provide new structs and functions (or just improve existing ones without changing their signature).Also the
reader::Decoder
struct is not public and not documented, butReader::decoder()
is... I guess either both or none should be public.The text was updated successfully, but these errors were encountered: