Do not generate empty Text events
#398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts generated for corresponding inputs
failures:
reader::test::borrowed::read_event_buffered::cdata
reader::test::borrowed::read_event_buffered::comment
reader::test::borrowed::read_event_buffered::declaration
reader::test::borrowed::read_event_buffered::doctype
reader::test::borrowed::read_event_buffered::empty
reader::test::borrowed::read_event_buffered::end
reader::test::borrowed::read_event_buffered::processing_instruction
reader::test::borrowed::read_event_buffered::start
reader::test::buffered::read_event_buffered::cdata
reader::test::buffered::read_event_buffered::comment
reader::test::buffered::read_event_buffered::declaration
reader::test::buffered::read_event_buffered::doctype
reader::test::buffered::read_event_buffered::empty
reader::test::buffered::read_event_buffered::end
reader::test::buffered::read_event_buffered::processing_instruction
reader::test::buffered::read_event_buffered::start
Codecov Report
@@ Coverage Diff @@
## master #398 +/- ##
==========================================
+ Coverage 61.37% 61.70% +0.32%
==========================================
Files 20 20
Lines 10157 10233 +76
==========================================
+ Hits 6234 6314 +80
+ Misses 3923 3919 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dralley
approved these changes
Jun 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #363
Just moving already existing check outside of
trim_text_startcheck was enough. Now useless emptyTextevents are not generated