Skip to content

Conversation

@Mingun
Copy link
Collaborator

@Mingun Mingun commented Sep 18, 2023

Closes #619.
@harmic, FYI

@Mingun Mingun requested a review from dralley September 18, 2023 17:04
@Mingun Mingun force-pushed the custom-errors-in-writing branch from b8d154d to 0ea9f74 Compare September 18, 2023 19:32
@codecov-commenter
Copy link

codecov-commenter commented Sep 18, 2023

Codecov Report

Merging #652 (d4f0621) into master (7866cf1) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
- Coverage   64.47%   64.46%   -0.01%     
==========================================
  Files          36       36              
  Lines       17315    17315              
==========================================
- Hits        11163    11162       -1     
- Misses       6152     6153       +1     
Flag Coverage Δ
unittests 64.46% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/writer/async_tokio.rs 75.14% <0.00%> (-0.23%) ⬇️
src/writer.rs 91.44% <100.00%> (-0.02%) ⬇️

Sometimes TortoiseGit loses commits during rebase... What a dangerous bug
@Mingun Mingun force-pushed the custom-errors-in-writing branch from 0ea9f74 to d4f0621 Compare September 24, 2023 19:47
@Mingun Mingun merged commit e1b2c46 into tafia:master Sep 25, 2023
@Mingun Mingun deleted the custom-errors-in-writing branch September 25, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provision for application errors in ElementWriter::write_inner_content

3 participants