A set of tiny fixes and improvements #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standard method considers more characters as whitespaces, but XML has its own set
The following calls are unnecessary, because this is the default values: .trim_text(false) .check_comments(false) .check_end_names(true) .expand_empty_elements(false)
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #658 +/- ##
==========================================
+ Coverage 64.50% 64.53% +0.02%
==========================================
Files 36 36
Lines 17286 17272 -14
==========================================
- Hits 11151 11147 -4
+ Misses 6135 6125 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dralley
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During work on various PRs I made a number of tiny improvements that helps with debugging. Them are not strictly related to any issue, so I put them together in this PR.
Also I noticed and fix one trivial mistake --
u8::is_ascii_whitespaceis used to find the boundary of a name of end tag instead of correctis_whitespace. Standard function considered more symbols as whitespaces, than XML requires.